Grouping Parentheses

[DarkTyger]

What do you think about adding GroupingParentheses to SpacesInParensOptions?

That is, GroupingParentheses: false would produce:

    if( (x + 5) == 7 ) { … }
    int x = (((3 + y) * (j - 5)) + (k * k));

Currently, when given:

SpacesInCStyleCastParentheses: true
SpacesInConditionalStatement: true
SpacesInContainerLiterals: false
SpacesInParentheses: true
SpacesInParens: Custom
SpacesInParensOptions:
  ExceptDoubleParentheses: false
  InConditionalStatements: true
  InCStyleCasts: true
  InEmptyParentheses: false
  Other: true

clang-format generates the far-too-spacious (IMO):

    if( ( x + 5 ) == 7 ) { … }
    int x = ( ( ( 3 + y ) * ( j - 5 ) ) + ( k * k ) );

[llvmbot]

@llvm/issue-subscribers-clang-format

Author: None (DarkTyger)

Details

What do you think about adding `GroupingParentheses` to `SpacesInParensOptions`?

That is, GroupingParentheses: false would produce:

    if( (x + 5) == 7 ) { … }
    int x = (((3 + y) * (j - 5)) + (k * k));

Currently, when given:

SpacesInCStyleCastParentheses: true
SpacesInConditionalStatement: true
SpacesInContainerLiterals: false
SpacesInParentheses: true
SpacesInParens: Custom
SpacesInParensOptions:
  ExceptDoubleParentheses: false
  InConditionalStatements: true
  InCStyleCasts: true
  InEmptyParentheses: false
  Other: true

clang-format generates the far-too-spacious (IMO):

    if( ( x + 5 ) == 7 ) { … }
    int x = ( ( ( 3 + y ) * ( j - 5 ) ) + ( k * k ) );

[tueda]

I'd like to configure clang-format for an existing project so that the formatted code looks like this:

int foo(int a, int b)
{
    if ( ( a + b ) * 2 == 10 ) {
        return a;
    }
    else {
        return b;
    }
}

However, the following configuration:

IndentWidth: 4
BreakBeforeBraces: Stroustrup
SpacesInParens: Custom
SpacesInParensOptions:
    InConditionalStatements: true
    Other: true

also results in spaces being inserted inside function arguments:

int foo( int a, int b )
{
    if ( ( a + b ) * 2 == 10 ) {
        return a;
    }
    else {
        return b;
    }
}

Setting GroupingParentheses to true instead of Other could address our problem, too.