`bugprone-nondeterministic-pointer-iteration-order` is only reported with libc++

[firewave]

#include <algorithm>
#include <vector>

struct S;

void f()
{
    std::vector<const S*> v;
    std::sort(v.begin(), v.end());
}

<source>:6:23: error: unknown type name 'S' [clang-diagnostic-error]
    6 |     std::vector<const S*> v;
      |                       ^

The warning is only shown when using libc++.

libstdc++: https://godbolt.org/z/543cGGnqq
libc++: https://godbolt.org/z/1Th935cvz

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: Oliver Stöneberg (firewave)

``` #include <algorithm> #include <vector>

void f()
{
std::vector<const S*> v;
std::sort(v.begin(), v.end());
}

<source>:6:23: error: unknown type name 'S' [clang-diagnostic-error]
6 | std::vector<const S*> v;
| ^

The warning is only shown when using libc++.

libstdc++: https://godbolt.org/z/543cGGnqq
libc++: https://godbolt.org/z/1Th935cvz
</details>

[chrchr-github]

Seems like the struct declaration is missing above, but present in the godbolt examples.

[firewave]

Seems like the struct declaration is missing above, but present in the godbolt examples.

Fixed.