Target is keeping an open handle to executable during test runs #24963
Description
| Bugzilla Link | 24589 |
| Version | unspecified |
| OS | Windows NT |
| Blocks | #22140 |
| Reporter | LLVM Bugzilla Contributor |
Extended Description
When running many test cases in the test suite, all operations happen within a single process. Most test suites simply clean and rebuild the entire executable with each test case which is currently necessary because a small number of tests (the exact set of which nobody is quite sure of) require this, and it is also necessary when switching between dsym and dwarf tests.
http://lists.llvm.org/pipermail/lldb-dev/2015-August/008073.html
On Windows, you can't delete the executable of a process that someone is holding a handle to, and due to some kind of bug in Target, a handle is sometimes behind held onto for reasons unknown.
This prevents all test cases after the first one to fail on the make clean step.
For now, a very hackish workaround has been implemented which will cause -- on Windows only -- Makefile.rules to use the builtin 'del' command instead of the 'rm' command that comes with GnuWin32. 'del' uses some kind of unknown technique to delete the file anyway, and this seems to have no other side effects.
Ultimately we need to fix
a) The test runner, so that it doesn't rebuild executables many times unnecessarily
and
b) LLDB, so that it properly frees process handles when it's done with them.
But this is an ok workaround for now, as long as we have this bug filed tracking the issue.