clang-format changes semantics of code on '#define keyword(x)' #31086
Assignees
Labels
bug
Indicates an unexpected problem or unintended behavior
bugzilla
Issues migrated from bugzilla
clang-format
confirmed
Verified by a second party
good first issue
https://github.com/llvm/llvm-project/contribute
invalid-code-generation
Tool (e.g. clang-format) produced invalid code that no longer compiles
Comments
mydeveloperday
added
bug
|
For the simple case of |
mkurdej
added
the
invalid-code-generation
|
Revision URI: https://reviews.llvm.org/D118844. |
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this issue
Oct 7, 2022
…acro when the name is a keyword. Fixes llvm/llvm-project#31086. Before the code: ``` #define if(x) ``` was erroneously formatted to: ``` #define if (x) ``` Reviewed By: HazardyKnusperkeks, owenpan Differential Revision: https://reviews.llvm.org/D118844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Extended Description
For certain keywords, '#define keyword(x)' will erroneously insert an extra space, causing the function-like macro to instead become an object-like macro. This can change the semantics of the compiled code, which should never happen.
The full list of affected C++ keywords seems to be:
and, and_eq, bitor, case, catch, delete, for, if, new, not_eq, or, or_eq, return, switch, try, while, xor, xor_eq. Additionally, the MSVC-specific __except is affected, and __try is not (but I haven't exhaustively tested all of MSVC's keywords.)
Note that this is not the same as the list of keywords which should be followed by a space when used normally according to the current style, or the list of keywords which are recognised by the preprocessor, or the list of keywords which it's grammatically valid for them to be followed by an open-parenthesis. In particular, note that bitor is affected, but bitand is not.
The text was updated successfully, but these errors were encountered: