Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge r344444 into the 7.0 branch : Optimize query in bugprone-exception-escape #38998

Closed
EugeneZelenko opened this issue Nov 13, 2018 · 8 comments
Closed

Merge r344444 into the 7.0 branch : Optimize query in bugprone-exception-escape #38998

EugeneZelenko opened this issue Nov 13, 2018 · 8 comments
Assignees
@tstellar
Labels
bugzilla Issues migrated from bugzilla

Comments

@EugeneZelenko
Copy link
Contributor

Bugzilla Link 39650
Resolution FIXED
Resolved on Dec 02, 2018 03:51
Version 7.0
OS All
Blocks #38454
CC @JonasToth,@tstellar
Fixed by commit(s) r344444 r344445 r347921

Extended Description

Is it OK to merge https://reviews.llvm.org/rCTE344444 into 7.0 branch?

There are two recent bug reports complained about performance of Clang-tidy in 7.0: bug 39167 and bug 39621.
@EugeneZelenko
Copy link
Contributor Author

assigned to @tstellar

@tstellar
Copy link
Collaborator

Hi Alex,

Is this OK to merge?

@llvmbot
Copy link
Member

llvmbot commented Nov 16, 2018

Yes, it should be fine to merge to 7.0.

@JonasToth
Copy link
Member

What needs to be done to merge this?
Asking because 30. november the deadline is done and clang-tidy's bugprone-* (something everyone should enable) is rendered useless with this bug, as it has super-linear behaviour.

@tstellar
Copy link
Collaborator

I will merge this.

@tstellar
Copy link
Collaborator

Looks like r344445 fixes a typo in this commit, so I'll merge that one too.

@tstellar
Copy link
Collaborator

Merged: r347921

@JonasToth
Copy link
Member

Thank you!

@tstellar tstellar mentioned this issue Sep 27, 2018
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tstellar tstellar

Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tstellar @JonasToth @EugeneZelenko @llvmbot