Skip to content

Merge r340125 into 7.0.1 #39252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
llvmbot opened this issue Dec 6, 2018 · 5 comments
Closed

Merge r340125 into 7.0.1 #39252

llvmbot opened this issue Dec 6, 2018 · 5 comments
Assignees
Labels
bugzilla Issues migrated from bugzilla

Comments

@llvmbot
Copy link
Member

llvmbot commented Dec 6, 2018

Bugzilla Link 39905
Resolution FIXED
Resolved on Dec 06, 2018 16:24
Version 7.0
OS All
Blocks #38454
Reporter LLVM Bugzilla Contributor
CC @tstellar
Fixed by commit(s) r340125 r348555

Extended Description

Hope this is not too late. It took our team a while to isolate the problem.

r340125 fixes allocation for common symbols in loading object code. The bug is doubling the allocation size per symbol and it will request way too much memory with a few dozens of common symbols.

We are seeing it trying to allocating >64GB of memory.

@llvmbot
Copy link
Member Author

llvmbot commented Dec 6, 2018

assigned to @tstellar

@tstellar
Copy link
Collaborator

tstellar commented Dec 6, 2018

We are already past the merge request deadline, so I'm not going to delay the release for this. However, if we can get it approved before I tag the next release candidate (likely Friday), then I'll merge it.

@tstellar
Copy link
Collaborator

tstellar commented Dec 6, 2018

Lang, does this look OK to merge: https://reviews.llvm.org/rL340125

@lhames
Copy link
Contributor

lhames commented Dec 6, 2018

Yep: that should be fine to merge.

@tstellar
Copy link
Collaborator

tstellar commented Dec 7, 2018

Merged: r348555

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

3 participants