clang-format: unexpected change on operator

[sylvestre]

Bugzilla Link	45357
Resolution	FIXED
Resolved on	May 07, 2020 11:11
Version	unspecified
OS	Linux
Blocks	#44654 #35642
CC	@mydeveloperday,@sylvestre,@tstellar
Fixed by commit(s)	eb85e90 b01dca5 7ae6db9 baeb500

Extended Description

with:
class UniquePtrGetterAddRefs {
operator void **() { return reinterpret_cast<void **>(&mPtrStorage); }
}

with clang-format 10.0

$ clang-format-10 foo.cpp
class UniquePtrGetterAddRefs {
operator void * *() { return reinterpret_cast<void **>(&mPtrStorage); }
}

I don't think it is what we want!

[sylvestre]

assigned to @sam-mccall

[sylvestre]

Similar example:

class ReturnToGlobal {
operator LocalRef*() { return &objRef; }
}

With!
$ clang-format-10 foo.cpp
class ReturnToGlobal {
operator LocalRef *() { return &objRef; }
}

Even with PointerAlignment: Left

[sylvestre]

@​MyDeveloperDay is that something you could help with? thanks

[mydeveloperday]

see https://reviews.llvm.org/D78879

The result is the following, is this that more like what is expected?

clang-format operator.cpp

class UniquePtrGetterAddRefs {
operator void **() { return reinterpret_cast<void **>(&mPtrStorage); }
}

class ReturnToGlobal {
operator LocalRef*() { return &objRef; }
}

[mydeveloperday]

A fix for this has landed

b01dca5

[tstellar]

Sam, are these OK to backport?

https://reviews.llvm.org/rGeb85e90350e93a64279139e7eca9ca40c8fbf5eb
https://reviews.llvm.org/rGb01dca50085768f1f1a5ad21a685906d48c38816

[sam-mccall]

Yes, both look good!

(The second doesn't cover operator T*&, but that's obscure enough that we don't need a backport I think)

[tstellar]

Merged: baeb500

[llvmbot]

mentioned in issue llvm/llvm-bugzilla-archive#45992