Clangd stability fixes for 10.0.1 #45615
Description
| Bugzilla Link | 46270 |
| Version | unspecified |
| OS | Linux |
| Blocks | #44654 |
| CC | @hokein,@kadircet,@tstellar |
Extended Description
As mentioned by email, these have already (erroneously) been merged.
Happy to revert any that we don't want.
Links are to the branch commits, they each reference the mainline commit from the description.
Trivial crash fixes in clangd:
2378a6e
30d05b8
52f2d6d
cb89646
c900824
d623a06
Other bugfixes in clangd:
7918dbd
357e79c
230b872
b6efa23
Trivial crash fixes in clang:
3f4a753
d942a81
The others that need a bit more explanation:
41c5efc
0530e2a
These commits together fix a clangd crasher, and aren't trivial. The change is in clang/lib/Syntax but this class currently has no users other than clangd.
cbc9b92
This fixes a clang AST serialization bug in a fairly mechanical way (an obscure field wasn't serialized, now it is). It was found through clangd but in principle affects other clang users.
38f995e
This is a fairly involved clangd-only fix for a high-profile crashing bug.
cd477e7
This is a small refactoring of a clang-tidy check that was crashing in certain scenarios when embedded in clangd - we weren't able to trigger it outside this environment. The fix simply reduces the lifetime of an object to avoid reentrancy.