[sparc] 254.gap does not compile with CBE

[llvmbot]

Bugzilla Link	190
Resolution	FIXED
Resolved on	Feb 22, 2010 12:55
Version	1.1
OS	Solaris
Reporter	LLVM Bugzilla Contributor
CC	@lattner

Extended Description

The 254.gap SPEC benchmark does not compile with the CBE on Sparc/Solaris. This
occurs because it enables LP64 compilation (SparcV9) but generates a prototype
for the write() system call of the wrong size (int).

[lattner]

I think that this is fixed. Can you check john?

-Chris

[llvmbot]

254.gap does not compile tonight on the Sparc with CBE. You get about 71 lines
of spew from gcc, but the error is definitely there:

Output/254.gap.cbe.c:76777: conflicting types for write' Output/254.gap.cbe.c:878: previous declaration of write'

[llvmbot]

Pardon me for asking stupid obvious questions, but can't we declare write() in
the C Writer to return ssize_t and include <unistd.h>? (The errors seem to me
to stem from the hardcoded def'n of write() in CWriter::visitUnwindInst().)

[lattner]

Sorry, but no, we can't. :)

The problem is that #includes of big headers like unistd.h pull in macros and
definitions that screw around with the .c file in unpredictable ways. This is
also the reason we have to have coniptions for alloca.

To fix this, the CWriter should use the lowerinvoke pass just like all of the
other backends. While we are at it, the CBE should be integrated into LLC...

Food for thought.

-Chris

[lattner]

Adding brian 'cause he didn't get the response to his q.

[lattner]

Can you check this now? As part of the CWriter using the lower-invoke pass, I
believe the problems with "write" should go away...

-Chris

[llvmbot]

Gap compiles on the SPARC with CBE now. Thanks Chris!