Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-prefer-member-init #62169

Closed
carlosgalvezp opened this issue Apr 17, 2023 · 1 comment · Fixed by #80330
Closed

[clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-prefer-member-init #62169

carlosgalvezp opened this issue Apr 17, 2023 · 1 comment · Fixed by #80330
Labels
clang-tidy code-cleanup
Milestone
LLVM 19.X Release

Comments

@carlosgalvezp
Copy link
Contributor

This functionality has been deprecated, moved to cppcoreguidelines-use-default-member-init, which is an alias of modernize-use-default-member-init. Remove the existing functionality in clang-tidy 19.
@carlosgalvezp carlosgalvezp added this to the LLVM 19.0.0 Release milestone Apr 17, 2023
@llvmbot
Copy link
Member

llvmbot commented Apr 17, 2023

@llvm/issue-subscribers-clang-tidy

carlosgalvezp pushed a commit to carlosgalvezp/llvm-project that referenced this issue Jan 31, 2024
[clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p…
bfa4ea3 
…refer-member-init

This functionality already exists in
cppcoreguidelines-use-default-member-init. It was deprecated from
this check in clang-tidy 17.

This allows us to fully decouple this check from the corresponding
modernize check, which has an unhealthy dependency.

Fixes llvm#62169
@carlosgalvezp carlosgalvezp mentioned this issue Jan 31, 2024
Closed
carlosgalvezp pushed a commit to carlosgalvezp/llvm-project that referenced this issue Feb 1, 2024
[clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p…
edac587 
…refer-member-init

This functionality already exists in
cppcoreguidelines-use-default-member-init. It was deprecated from
this check in clang-tidy 17.

This allows us to fully decouple this check from the corresponding
modernize check, which has an unhealthy dependency.

Fixes llvm#62169
carlosgalvezp pushed a commit to carlosgalvezp/llvm-project that referenced this issue Feb 1, 2024
[clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p…
e3b3d8b 
…refer-member-init

This functionality already exists in
cppcoreguidelines-use-default-member-init. It was deprecated from
this check in clang-tidy 17.

This allows us to fully decouple this check from the corresponding
modernize check, which has an unhealthy dependency.

Fixes llvm#62169
@carlosgalvezp carlosgalvezp mentioned this issue Feb 1, 2024
Merged
carlosgalvezp added a commit that referenced this issue Feb 1, 2024
@carlosgalvezp
[clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p…
6f32d6a 
…refer-member-init (#80330)

This functionality already exists in
cppcoreguidelines-use-default-member-init. It was deprecated from this
check in clang-tidy 17.

This allows us to fully decouple this check from the corresponding
modernize check, which has an unhealthy dependency.

Fixes #62169

---------

Co-authored-by: Carlos Gálvez <carlos.galvez@zenseact.com>
agozillon pushed a commit to agozillon/llvm-project that referenced this issue Feb 5, 2024
@carlosgalvezp @agozillon
[clang-tidy] Remove enforcement of rule C.48 from cppcoreguidelines-p…
0eb1175 
…refer-member-init (llvm#80330)

This functionality already exists in
cppcoreguidelines-use-default-member-init. It was deprecated from this
check in clang-tidy 17.

This allows us to fully decouple this check from the corresponding
modernize check, which has an unhealthy dependency.

Fixes llvm#62169

---------

Co-authored-by: Carlos Gálvez <carlos.galvez@zenseact.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang-tidy code-cleanup
Projects
None yet
Milestone
LLVM 19.X Release
2 participants
@carlosgalvezp @llvmbot