[OSX][TargetLibraryInfo] strrchr is replaced to non-existed memrchr

[kpdev]

On Mac OSX (macOS version 12.4, sdk version 12.1) llvm can replace call to strrchr() with call to memrchr() when string length is known at compile time. This results in link error, because memrchr is not present in libSystem. It is needed to disable this optimization in TargetLibraryInfo for affected OSX versions.

[kpdev]

Can I help to solve it somehow? Maybe some additional info is needed? @badger200 @EugeneZelenko

[mohd-akram]

Any update on merging this? This issue is in LLVM 15 and 16, and is breaking packages that use strrchr on macOS. Hopefully it can be fixed before LLVM 17.

[Endilll]

@mohd-akram I'd say if you want to get this into 17, you have to nag reviewers hard enough to get it reviewed and landed during the upcoming week.

[mohd-akram]

This was fixed in a7a6ef3, but it's still not in LLVM 17 as of 17.0.6.

[mohd-akram]

@tru Maybe this can be cherry-picked for 17?

[Endilll]

@mohd-akram Commit you referenced landed ≈3 weeks after 17 cut-off, so it didn't make it into the first 17 release. No one put effort to cherry-pick it into subsequent 17 releases, so it didn't make it into 17.0.6 either. We are close to 18 cut-off now, and this commit will make it in there.