Skip to content

Merge 96abee5eef31274415681018553e1d4a16dc16c9 into 18.x #82869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brad0 opened this issue Feb 24, 2024 · 3 comments
Closed

Merge 96abee5eef31274415681018553e1d4a16dc16c9 into 18.x #82869

brad0 opened this issue Feb 24, 2024 · 3 comments

Comments

@brad0
Copy link
Contributor

brad0 commented Feb 24, 2024

[Mips] Fix unable to handle inline assembly ends with compat-branch on MIPS (#77291)

Modify:
Add a global variable 'CurForbiddenSlotAttr' to save current
instruction's forbidden slot and whether set reorder. This is the
judgment condition for whether to add nop. We would add a couple of
'.set noreorder' and '.set reorder' to wrap the current instruction and
the next instruction.
Then we can get previous instruction`s forbidden slot attribute and
whether set reorder by 'CurForbiddenSlotAttr'.
If previous instruction has forbidden slot and .set reorder is active
and current instruction is CTI. Then emit a NOP after it.

Fix #61045.

Because https://reviews.llvm.org/D158589 was 'Needs Review' state, not
ending, so we commit pull request again.

@brad0
Copy link
Contributor Author

brad0 commented Feb 24, 2024

/cherry-pick 96abee5

@llvmbot llvmbot closed this as completed Feb 24, 2024
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in LLVM Release Status Feb 24, 2024
@llvmbot
Copy link
Member

llvmbot commented Feb 24, 2024

/pull-request #82870

@llvmbot
Copy link
Member

llvmbot commented Feb 24, 2024

@llvm/issue-subscribers-backend-mips

Author: Brad Smith (brad0)

[Mips] Fix unable to handle inline assembly ends with compat-branch on MIPS (#77291)

Modify:
Add a global variable 'CurForbiddenSlotAttr' to save current
instruction's forbidden slot and whether set reorder. This is the
judgment condition for whether to add nop. We would add a couple of
'.set noreorder' and '.set reorder' to wrap the current instruction and
the next instruction.
Then we can get previous instruction`s forbidden slot attribute and
whether set reorder by 'CurForbiddenSlotAttr'.
If previous instruction has forbidden slot and .set reorder is active
and current instruction is CTI. Then emit a NOP after it.

Fix #61045.

Because https://reviews.llvm.org/D158589 was 'Needs Review' state, not
ending, so we commit pull request again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants