lldb/source/Core/Debugger.cpp:1118: Pointless code ?

[dcb314]

lldb/source/Core/Debugger.cpp:1118:9: warning: Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition]

Source code is

while (top_reader_sp) {
if (!top_reader_sp)
break;

[llvmbot]

@llvm/issue-subscribers-lldb

Author: None (dcb314)

lldb/source/Core/Debugger.cpp:1118:9: warning: Opposite inner 'if' condition leads to a dead code block. [oppositeInnerCondition]

Source code is

while (top_reader_sp) {
if (!top_reader_sp)
break;

[Troy-Butler]

Hi, could you please assign this to me?

[jryans]

@Troy-Butler I would suggest just working towards a PR, and then submit that when you have it ready.

[Troy-Butler]

I really need for it to be assigned to me. I'm making contributions for a project, and they don't count if I'm not assigned.

[bulbazord]

I really need for it to be assigned to me. I'm making contributions for a project, and they don't count if I'm not assigned.

I see you've been asking to be assigned several issues. I'm not sure about other subprojects, but for LLDB there's no policy or precedent for claiming an issue before opening a PR to address an issue (unless you filed the issue and assigned it to yourself). Could you give us some more context about what you're doing? I'd be happy to assign this issue to you after learning a bit more about your situation.

[Troy-Butler]

I understand. I'm a university student working on a project for a software development course. The project involves contributing to open source projects, and requires that I am assigned to existing issues and that my pull requests are successfully accepted/merged.

[bulbazord]

Thanks for the explanation. I've assigned you this issue, feel free to add me as a reviewer on the associated PR.