Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DXIL] Add abs lowering #86155

Closed
Tracked by #29
farzonl opened this issue Mar 21, 2024 · 0 comments · Fixed by #86158
Closed
Tracked by #29

[DXIL] Add abs lowering #86155

farzonl opened this issue Mar 21, 2024 · 0 comments · Fixed by #86158
Assignees
@farzonl
Labels
backend:DirectX

Comments

@farzonl
Copy link
Member

farzonl commented Mar 21, 2024

Abs frontend work is completed but there is no dxil op lowering.

Lowering should cover: https://godbolt.org/z/nexTfW8hE
@farzonl farzonl self-assigned this Mar 21, 2024
farzonl added a commit to farzonl/llvm-project that referenced this issue Mar 21, 2024
@farzonl
[DXIL] Complete abs lowering
18598a7 
This change completes llvm#86155
- `DXIL.td` - lowering `fabs` intrinsic to the float dxil op.
- `DXILIntrinsicExpansion.cpp` - Add intrinsic expansion for the abs
  case.
@farzonl farzonl mentioned this issue Mar 21, 2024
Merged
@farzonl farzonl moved this to Active in HLSL Support Mar 21, 2024
@farzonl farzonl linked a pull request Mar 21, 2024 that will close this issue
[DXIL] Complete abs lowering #86158
Merged
farzonl added a commit that referenced this issue Mar 22, 2024
@farzonl
[DXIL] Complete abs lowering (#86158)
d8e5c0b 
This change completes #86155
- `DXIL.td` - lowering `fabs` intrinsic to the float dxil op.
- `DXILIntrinsicExpansion.cpp` - Add intrinsic expansion for the abs
case.
@github-project-automation github-project-automation bot moved this from Active to Done in HLSL Support Mar 22, 2024
chencha3 pushed a commit to chencha3/llvm-project that referenced this issue Mar 23, 2024
@farzonl @chencha3
[DXIL] Complete abs lowering (llvm#86158)
f6709c1 
This change completes llvm#86155
- `DXIL.td` - lowering `fabs` intrinsic to the float dxil op.
- `DXILIntrinsicExpansion.cpp` - Add intrinsic expansion for the abs
case.
This was referenced Aug 5, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farzonl farzonl

Labels
backend:DirectX
Projects
HLSL Support
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DXIL] Complete abs lowering farzonl/llvm-project
1 participant
@farzonl