Skip to content

Assertion in Scalar Evolution when running IRCE #89959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gbaraldi opened this issue Apr 24, 2024 · 2 comments · Fixed by #89967
Closed

Assertion in Scalar Evolution when running IRCE #89959

gbaraldi opened this issue Apr 24, 2024 · 2 comments · Fixed by #89967
Assignees
@dtcxzyw
Labels
crash-on-valid llvm:SCEV Scalar Evolution
Milestone
LLVM 18.X Release

Comments

@gbaraldi
Copy link
Contributor

The following IR crashes with

define void @foo() {
top:
  br label %L3

L3:                                               ; preds = %L13, %top
  %value_phi = phi ptr [ null, %top ], [ %0, %L13 ]
  %0 = getelementptr i8, ptr %value_phi, i64 8
  %.not = icmp ule ptr %value_phi, null
  br i1 %.not, label %L13, label %L15

L13:                                              ; preds = %L3
  br label %L3

L15:                                              ; preds = %L3
  ret void
}

opt --passes=irce

https://godbolt.org/z/1sbvaT7r1
@dtcxzyw dtcxzyw added llvm:SCEV Scalar Evolution crash-on-valid and removed new issue labels Apr 24, 2024
@dtcxzyw dtcxzyw self-assigned this Apr 24, 2024
@gbaraldi gbaraldi mentioned this issue Apr 24, 2024
Merged
@dtcxzyw dtcxzyw mentioned this issue Apr 24, 2024
Merged
dtcxzyw added a commit that referenced this issue Apr 26, 2024
@dtcxzyw
[IRCE] Skip icmp ptr in InductiveRangeCheck::parseRangeCheckICmp (#…

Verified

This commit was signed with the committer’s verified signature.
zeripath
GPG key ID: 3CDE74631F13A748
Verified
Learn about vigilant mode
22da5a6 
…89967)

Fixes #89959.
@nikic nikic added this to the LLVM 18.X Release milestone Apr 26, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in LLVM Release Status Apr 26, 2024
@nikic
Copy link
Contributor

nikic commented Apr 26, 2024

/cherry-pick 22da5a6

llvmbot pushed a commit to llvmbot/llvm-project that referenced this issue Apr 26, 2024
@dtcxzyw @llvmbot
[IRCE] Skip icmp ptr in InductiveRangeCheck::parseRangeCheckICmp (l…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6fdc67c 
…lvm#89967)

Fixes llvm#89959.

(cherry picked from commit 22da5a6)
@llvmbot
Copy link
Member

llvmbot commented Apr 26, 2024

/pull-request #90182

gbaraldi pushed a commit to JuliaLang/llvm-project that referenced this issue Apr 26, 2024
@dtcxzyw @gbaraldi
[IRCE] Skip icmp ptr in InductiveRangeCheck::parseRangeCheckICmp (l…

Verified

This commit was signed with the committer’s verified signature.
zeripath
GPG key ID: 3CDE74631F13A748
Verified
Learn about vigilant mode
0424864 
…lvm#89967)

Fixes llvm#89959.
@tstellar tstellar moved this from Needs Triage to Done in LLVM Release Status Apr 27, 2024
tstellar pushed a commit to llvmbot/llvm-project that referenced this issue Apr 29, 2024
@dtcxzyw @tstellar
[IRCE] Skip icmp ptr in InductiveRangeCheck::parseRangeCheckICmp (l…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
abf6b13 
…lvm#89967)

Fixes llvm#89959.

(cherry picked from commit 22da5a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtcxzyw dtcxzyw

Labels
crash-on-valid llvm:SCEV Scalar Evolution
Projects
LLVM Release Status
Status: Done
Milestone
LLVM 18.X Release
Development

Successfully merging a pull request may close this issue.

[IRCE] Skip icmp ptr in InductiveRangeCheck::parseRangeCheckICmp dtcxzyw/llvm-project
4 participants
@nikic @dtcxzyw @gbaraldi @llvmbot