Skip to content

[llvm-lit][test] Precommit tests for lit's built-in cat command #101530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

[llvm-lit][test] Precommit tests for lit's built-in cat command #101530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dee2254
[llvm-lit][test] Adding tests for lit's built-in cat command
connieyzhu Aug 1, 2024
9c2fb03
[llvm-lit] Combined test files to separate by option for cat
connieyzhu Aug 2, 2024
1b7d6a6
[llvm-lit] Added more clarifying comments + minor syntax changes
connieyzhu Aug 2, 2024
ff3f7e6
[llvm-lit] Added allchars test for cat
connieyzhu Aug 2, 2024
08082d1
[llvm-lit] Changed CHECK directives for more check precision
connieyzhu Aug 2, 2024
626882f
[llvm-lit] Fixed darker formatting issue
connieyzhu Aug 2, 2024
5d13daa
[llvm-lit][test] Added cat -e tests to existing cat testing file
connieyzhu Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions llvm/utils/lit/tests/Inputs/shtest-shell/valid-shell.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,3 +169,23 @@
# NPLONG-CAT-OUTPUT-NEXT: M-HM-IM-JM-KM-LM-MM-NM-OM-PM-QM-RM-SM-TM-UM-VM-WM-XM-YM-ZM-[
# NPLONG-CAT-OUTPUT-NEXT: M-\M-]M-^M-_M-`M-aM-bM-cM-dM-eM-fM-gM-hM-iM-jM-kM-lM-mM-nM-o
# NPLONG-CAT-OUTPUT-NEXT: M-pM-qM-rM-sM-tM-uM-vM-wM-xM-yM-zM-{M-|M-}M-~M-^?
#
## Check cat command with -e option.
## -e will convert text to ^ and M- notation and append a '$' to each new line.
#
# RUN: cat -e %S/cat_nonprinting.bin \
# RUN: | FileCheck --check-prefix=NPE-CAT-OUTPUT --implicit-check-not={{.}} --match-full-lines --strict-whitespace %s
# NPE-CAT-OUTPUT:^@^A^B^C^D^E^F^G ^H$
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, for readability, I might add some spacing as in the suggestion, so that the colons line up.

Suggested change
# NPE-CAT-OUTPUT:^@^A^B^C^D^E^F^G ^H$
# NPE-CAT-OUTPUT:^@^A^B^C^D^E^F^G ^H$

# NPE-CAT-OUTPUT-NEXT:^K^L^M^N^O^P^Q^R^S$
# NPE-CAT-OUTPUT-NEXT:^T^U^V^W^X^Y^Z^[^\^]^^^_ !"#$%&'$
# NPE-CAT-OUTPUT-NEXT:()*+,-./0123456789:;$
# NPE-CAT-OUTPUT-NEXT:<=>?@ABCDEFGHIJKLMNO$
# NPE-CAT-OUTPUT-NEXT:PQRSTUVWXYZ[\]^_`abc$
# NPE-CAT-OUTPUT-NEXT:defghijklmnopqrstuvw$
# NPE-CAT-OUTPUT-NEXT:xyz{|}~^?M-^@M-^AM-^BM-^CM-^DM-^EM-^FM-^GM-^HM-^IM-^JM-^K$
# NPE-CAT-OUTPUT-NEXT:M-^LM-^MM-^NM-^OM-^PM-^QM-^RM-^SM-^TM-^UM-^VM-^WM-^XM-^YM-^ZM-^[M-^\M-^]M-^^M-^_$
# NPE-CAT-OUTPUT-NEXT:M- M-!M-"M-#M-$M-%M-&M-'M-(M-)M-*M-+M-,M--M-.M-/M-0M-1M-2M-3$
# NPE-CAT-OUTPUT-NEXT:M-4M-5M-6M-7M-8M-9M-:M-;M-<M-=M->M-?M-@M-AM-BM-CM-DM-EM-FM-G$
# NPE-CAT-OUTPUT-NEXT:M-HM-IM-JM-KM-LM-MM-NM-OM-PM-QM-RM-SM-TM-UM-VM-WM-XM-YM-ZM-[$
# NPE-CAT-OUTPUT-NEXT:M-\M-]M-^M-_M-`M-aM-bM-cM-dM-eM-fM-gM-hM-iM-jM-kM-lM-mM-nM-o$
# NPE-CAT-OUTPUT-NEXT:M-pM-qM-rM-sM-tM-uM-vM-wM-xM-yM-zM-{M-|M-}M-~M-^?$
4 changes: 2 additions & 2 deletions llvm/utils/lit/tests/shtest-shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,6 @@
# CHECK: false
# CHECK: ***

# CHECK: PASS: shtest-shell :: valid-shell.txt
# CHECK: FAIL: shtest-shell :: valid-shell.txt
# CHECK: Unresolved Tests (1)
# CHECK: Failed Tests (38)
# CHECK: Failed Tests (39)