[SandboxIR][Tracker] Track InsertIntoBB #101595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vporpo
requested review from
slackito,
echristo,
alinas,
tschuett,
aeubanks,
tmsri and
Sterling-Augustine
tschuett
reviewed
Aug 2, 2024
| @@ -291,6 +291,22 @@ class MoveInstr : public IRChangeBase { | |||
| #endif // NDEBUG | |||
| }; | |||
|
|
|||
| class InsertIntoBB : public IRChangeBase { | |||
There was a problem hiding this comment.
class InsertIntoBB final : public IRChangeBase { ?
There was a problem hiding this comment.
Yeah, I think all of them should be marked as final.
aeubanks
approved these changes
Aug 2, 2024
| void revert() final; | ||
| void accept() final {} | ||
| #ifndef NDEBUG | ||
| void dump(raw_ostream &OS) const final { |
There was a problem hiding this comment.
you may consider some CRTP to automate dump methods, like
(still doesn't address the gdb issue of not being able to call methods in parent classes, but something to think about)
There was a problem hiding this comment.
Yeah I have to fix both these dumps and the Value dumps.
This tracks the insertion of an Instruction into a BasicBlock.
kutemeikito
added a commit
to kutemeikito/llvm-project
that referenced
this pull request
Aug 4, 2024
* 'main' of https://github.com/llvm/llvm-project: [RISCV] Improve hasAllNBitUsers for users of SLLI. [RISCV] Invert if conditions in the switch in RISCVDAGToDAGISel::hasAllNBitUsers. NFC [Transforms] Construct SmallVector with ArrayRef (NFC) (llvm#101851) [RISCV] Capitalize some variable names. NFC [sanitizer_common] Fix UnwindFast on SPARC (llvm#101634) [builtins] Fix divtc3.c etc. compilation on Solaris/SPARC with gcc (llvm#101662) [NFC][asan] Track current dynamic init module (llvm#101597) [libc] enable most of the entrypoints on aarch64 (llvm#101797) [SandboxIR][Tracker] Track InsertIntoBB (llvm#101595) [SCEV] Use const SCEV * explicitly in more places. [ELF] Move outputSections into Ctx. NFC [ELF] Move ElfSym into Ctx. NFC [ELF] Move Out into Ctx. NFC [test][asan] Fix the test checks [NFC][asan] Switch from list to DynInitGlobalsByModule (llvm#101596) Signed-off-by: Edwiin Kusuma Jaya <kutemeikito0905@gmail.com>
banach-space
pushed a commit
to banach-space/llvm-project
that referenced
this pull request
Aug 7, 2024
This patch implements tracking for the insertion of a sandboxir::Instruction into a sandboxir::BasicBlock.
kstoimenov
pushed a commit
to kstoimenov/llvm-project
that referenced
this pull request
Aug 15, 2024
This patch implements tracking for the insertion of a sandboxir::Instruction into a sandboxir::BasicBlock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements tracking for the insertion of a sandboxir::Instruction into a sandboxir::BasicBlock.