Skip to content

[mlir][vector] Add more tests for ConvertVectorToLLVM (1/n) #101936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
banach-space merged 2 commits into from
Aug 8, 2024
Merged

[mlir][vector] Add more tests for ConvertVectorToLLVM (1/n) #101936

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18b4cf4
[mlir][vector] Add more tests for ConvertVectorToLLVM (1/n)
banach-space Aug 4, 2024
f2e1ec8
fixup! [mlir][vector] Add more tests for ConvertVectorToLLVM (1/n)
banach-space Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mlir/lib/Dialect/Vector/IR/VectorOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2405,7 +2405,10 @@ BroadcastableToResult mlir::vector::isBroadcastableTo(
bool srcDimScalableFlag = srcVectorType.getScalableDims()[dimIdx];
bool dstDimScalableFlag = dstVectorType.getScalableDims()[lead + dimIdx];
if ((srcDim == 1 && srcDimScalableFlag && dstDim != 1) ||
(srcDimScalableFlag != dstDimScalableFlag))
// 1 -> [N] is fine, everything else should be rejected when mixing
// fixed-width and scalable dims
(srcDimScalableFlag != dstDimScalableFlag &&
(srcDim != 1 || srcDimScalableFlag)))
foundMismatchingDims = true;

if (foundMismatchingDims) {
Expand Down
7 changes: 6 additions & 1 deletion mlir/lib/Dialect/Vector/Transforms/LowerVectorBroadcast.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ class BroadcastOpLowering : public OpRewritePattern<vector::BroadcastOp> {
// ..
// %x = [%a,%b,%c,%d]
VectorType resType =
VectorType::get(dstType.getShape().drop_front(), eltType);
VectorType::get(dstType.getShape().drop_front(), eltType,
dstType.getScalableDims().drop_front());
Value result = rewriter.create<arith::ConstantOp>(
loc, dstType, rewriter.getZeroAttr(dstType));
if (m == 0) {
Expand All @@ -136,6 +137,10 @@ class BroadcastOpLowering : public OpRewritePattern<vector::BroadcastOp> {
result = rewriter.create<vector::InsertOp>(loc, bcst, result, d);
} else {
// Stetch not at start.
if (dstType.getScalableDims()[0]) {
// TODO: For scalable vectors we should emit an scf.for loop.
return failure();
}
for (int64_t d = 0, dim = dstType.getDimSize(0); d < dim; ++d) {
Value ext = rewriter.create<vector::ExtractOp>(loc, op.getSource(), d);
Value bcst = rewriter.create<vector::BroadcastOp>(loc, resType, ext);
Expand Down
Loading