Skip to content

[libcxx][test] Add feature for platforms where long double is double #103903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[libcxx][test] Add feature for platforms where long double is double #103903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07d5be2
[libcxx][test] Add feature for platforms where sizeof(long double) ==…
DavidSpickett Aug 14, 2024
1fb787c
xfail instead.
DavidSpickett Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions libcxx/test/std/language.support/cmp/cmp.alg/strong_order_long_double.verify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,7 @@

// UNSUPPORTED: c++03, c++11, c++14, c++17

// The following platforms have sizeof(long double) == sizeof(double), so this test doesn't apply to them.
// This test does apply to aarch64 where Arm's AAPCS64 is followed. There they are different sizes.
// XFAIL: target={{arm64|arm64e|armv(7|8)(l|m)?|powerpc|powerpc64}}-{{.+}}

// MSVC configurations have long double equal to regular double on all
// architectures.
// XFAIL: target={{.+}}-pc-windows-msvc

// ARM/AArch64 MinGW also has got long double equal to regular double, just
// like MSVC (thus match both MinGW and MSVC here, for those architectures).
// XFAIL: target={{aarch64|armv7}}-{{.*}}-windows-{{.+}}

// Android's 32-bit x86 target has long double equal to regular double.
// XFAIL: target=i686-{{.+}}-android{{.*}}
// XFAIL: long-double-is-double

// <compare>

Expand Down
12 changes: 12 additions & 0 deletions libcxx/utils/libcxx/test/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,18 @@ def _mingwSupportsModules(cfg):
""",
),
),
Feature(
name="long-double-is-double",
when=lambda cfg: sourceBuilds(
cfg,
"""
int main(int, char**) {
static_assert(sizeof(long double) == sizeof(double));
return 0;
}
""",
),
),
# Check for a Windows UCRT bug (fixed in UCRT/Windows 10.0.20348.0):
# https://developercommunity.visualstudio.com/t/utf-8-locales-break-ctype-functions-for-wchar-type/1653678
Feature(
Expand Down