[analyzer] Add missing include <unordered_map> to llvm/lib/Support/Z3Solver.cpp

[lukeshingles]

Resolves #106361. Adding #include <unordered_map> to llvm/lib/Support/Z3Solver.cpp fixes compilation errors for homebrew build on macOS with Xcode 14. https://github.com/Homebrew/homebrew-core/actions/runs/10604291631/job/29390993615?pr=181351 shows that this is resolved when the include is patched in (Linux CI failure is due to unrelated timeout).

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-llvm-support

Author: Luke Shingles (lukeshingles)

Changes

Resolves #106361. The homebrew build with #include <unordered_map> patched into Z3Solver.cpp (https://github.com/Homebrew/homebrew-core/actions/runs/10595188343/job/29362431446?pr=181351) now compiles (new failures are homebrew specific issues related to blocking non-release versions in macOS or CI 6 hr timeout on Linux).

---

Full diff: https://github.com/llvm/llvm-project/pull/106410.diff

1 Files Affected:

• (modified) llvm/lib/Support/Z3Solver.cpp (+1)

diff --git a/llvm/lib/Support/Z3Solver.cpp b/llvm/lib/Support/Z3Solver.cpp
index 5a34ff160f6cf4..9aece099b06295 100644
--- a/llvm/lib/Support/Z3Solver.cpp
+++ b/llvm/lib/Support/Z3Solver.cpp
@@ -19,6 +19,7 @@ using namespace llvm;
 #include "llvm/ADT/Twine.h"
 
 #include <set>
+#include <unordered_map>
 
 #include <z3.h>
 

[tamird]

Will also need to be cherry-picked in https://github.com/llvm/llvm-project/tree/release/19.x.

[lukeshingles]

@NagyDonat since you reviewed #97265, maybe you can review this fix?

[github-actions]

@lukeshingles Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

[tamird]

/cherry-pick 63c3de4

[llvmbot]

/cherry-pick 63c3de4

Error: Command failed due to missing milestone.

[tamird]

/cherry-pick 63c3de4

[llvmbot]

Failed to cherry-pick: 63c3de4

https://github.com/llvm/llvm-project/actions/runs/10613204816

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

[tamird]

/cherry-pick fcb3a04

[llvmbot]

/pull-request #106525