Skip to content

Conversation

@llvmbot
Copy link
Member

@llvmbot llvmbot commented Aug 29, 2024

Backport 2a28df6

Requested by: @zmodem

)

When including all targets, some files become too large for the NSIS
installer to handle.

Fixes llvm#101994

(cherry picked from commit 2a28df6)
@tru tru merged commit 1b643db into llvm:release/19.x Sep 1, 2024
@github-actions
Copy link

github-actions bot commented Sep 1, 2024

@zmodem (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

@zmodem
Copy link
Collaborator

zmodem commented Sep 2, 2024

@zmodem (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

How about:

"Starting with LLVM 19, the Windows installers only include support for the X86, ARM, and AArch64 targets in order to keep the build size within the limits of the NSIS installer framework."

@zmodem
Copy link
Collaborator

zmodem commented Sep 9, 2024

@tru can I do something to help get that release note ^ into the release?

@tru
Copy link
Collaborator

tru commented Sep 9, 2024

@tru can I do something to help get that release note ^ into the release?

I think for the initial release we'll just use the release notes document in the docs folder as usual. So I would add it to LLVM release notes and give me PR for that.

@zmodem
Copy link
Collaborator

zmodem commented Sep 9, 2024

Sent #107826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants