Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clang] Workaround dependent source location issues #106925

Merged
merged 3 commits into from
Sep 4, 2024

Commits on Sep 2, 2024

  1. [Clang] Workaround dependent source location issues

    In llvm#78436 we made some SourceLocExpr dependent to
    deal with the fact that their value should reflect the name of
    specialized function - rather than the rtemplate in which they
    are first used.
    
    However SourceLocExpr are unusual in two ways
     - They don't depend on template argumente
     - They morally depend on the context in which they are used
       (rather than called from).
    
    It's fair to say that this is quite novels and confuses
    clang. In particular, in some cases, we used to create
    dependent SourceLocExpr and never subsequently transform them,
    leaving dependent objects in instantiated functions types.
    To work around that we avoid replacing SourceLocExpr when we think
    they could remain dependent.
    It's certainly not perfect but it fixes a number of reported bugs,
    and seem to only affect scenarios in which the value of the
    SourceLocExpr does not matter (overload resolution).
    
    Fixes llvm#106428
    Fixes llvm#81155
    cor3ntin committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    6544062 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Fix typos

    Co-authored-by: Aaron Ballman <aaron@aaronballman.com>
    cor3ntin and AaronBallman authored Sep 3, 2024
    Configuration menu
    Copy the full SHA
    db0cf1e View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    8b33dc1 View commit details
    Browse the repository at this point in the history