Skip to content

[lldb] Support partial memory reads on windows #106981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[lldb] Support partial memory reads on windows #106981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions lldb/source/Plugins/Process/Windows/Common/ProcessDebugger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,16 +276,29 @@ Status ProcessDebugger::ReadMemory(lldb::addr_t vm_addr, void *buf, size_t size,
LLDB_LOG(log, "attempting to read {0} bytes from address {1:x}", size,
vm_addr);

HostProcess process = m_session_data->m_debugger->GetProcess();
lldb::process_t handle = m_session_data->m_debugger->GetProcess()
.GetNativeProcess()
.GetSystemHandle();
void *addr = reinterpret_cast<void *>(vm_addr);
SIZE_T num_of_bytes_read = 0;
if (!::ReadProcessMemory(process.GetNativeProcess().GetSystemHandle(), addr,
buf, size, &num_of_bytes_read)) {
error = Status(GetLastError(), eErrorTypeWin32);
LLDB_LOG(log, "reading failed with error: {0}", error);
} else {
if (::ReadProcessMemory(handle, addr, buf, size, &num_of_bytes_read)) {
bytes_read = num_of_bytes_read;
return Status();
}
error = Status(GetLastError(), eErrorTypeWin32);
MemoryRegionInfo info;
if (GetMemoryRegionInfo(vm_addr, info).Fail() ||
info.GetMapped() != MemoryRegionInfo::OptionalBool::eYes)
return error;
size = info.GetRange().GetRangeEnd() - vm_addr;
LLDB_LOG(log, "retrying the read with size {0:x}", size);
if (::ReadProcessMemory(handle, addr, buf, size, &num_of_bytes_read)) {
LLDB_LOG(log, "success: read {0:x} bytes", num_of_bytes_read);
bytes_read = num_of_bytes_read;
return Status();
}
error = Status(GetLastError(), eErrorTypeWin32);
LLDB_LOG(log, "error: {0}", error);
return error;
}

Expand Down
1 change: 0 additions & 1 deletion lldb/test/API/functionalities/memory/holes/TestMemoryHoles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ def _prepare_inferior(self):
]
self.assertEqual(len(self.positions), 5)

@expectedFailureWindows
def test_memory_read(self):
self._prepare_inferior()

Expand Down