[CGData] Stable Function Map #112662
Merged
[CGData] Stable Function Map #112662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyulee-com
force-pushed
the
users/kyulee-com/funcmap
branch
from
e7272c3 to
060a23e
Compare
kyulee-com
force-pushed
the
users/kyulee-com/strhash
branch
from
a61dd8e to
d3c35a7
Compare
kyulee-com
force-pushed
the
users/kyulee-com/funcmap
branch
from
060a23e to
7d9dc40
Compare
These define the main data structures to represent stable functions and group similar functions in a function map. Serialization is supported in a binary or yaml form.
kyulee-com
force-pushed
the
users/kyulee-com/funcmap
branch
from
7d9dc40 to
8e10ed3
Compare
|
cc. @nocchijiang |
ellishg
reviewed
Oct 28, 2024
| void StableFunctionMap::finalize() { | ||
| Finalized = true; | ||
|
|
||
| for (auto It = HashToFuncs.begin(); It != HashToFuncs.end(); ++It) { |
There was a problem hiding this comment.
Just want to point out this this iterates over a DenseMap, which is not deterministic. Hopefully the iteration order doesn't matter. But if they are truly independent, can we use llvm::parallelFor()? I only see that used in lld, so I'm not sure it makes sense here.
There was a problem hiding this comment.
As an entry can be deleted on the fly, we can't use a parallel loop.
Do you have any comment on this direction? |
thevinster
approved these changes
Oct 31, 2024
| }; | ||
|
|
||
| /// An efficient form of StableFunction for fast look-up | ||
| struct StableFunctionEntry { |
There was a problem hiding this comment.
Should this be an internal implementation within StableFunctionMap? It doesn't seem like it could be defined without a StableFunctionMap calculating the Ids, right? We could always make this public again if there is a use case for it.
There was a problem hiding this comment.
There is a use case In the StableFunctionMapRecord. However, I agree that the insert(FuncEntry) method should remain private, as its usage should be restricted to within this context. So, I have utilized the friend keyword while keeping it private, and removed the inapplicable test case.
| /// Insert a `StableFunctionEntry` into the function map directly. This | ||
| /// method assumes that string names have already been uniqued and the | ||
| /// `StableFunctionEntry` is ready for insertion. | ||
| void insert(std::unique_ptr<StableFunctionEntry> FuncEntry) { |
There was a problem hiding this comment.
If StableFunctionEntry is private, then this method can be private too.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/151/builds/3027 Here is the relevant piece of the build log for the reference |
smallp-o-p
pushed a commit
to smallp-o-p/llvm-project
that referenced
this pull request
Nov 3, 2024
These define the main data structures to represent stable functions and group similar functions in a function map. Serialization is supported in a binary or yaml form. Depends on llvm#112638. This is a patch for https://discourse.llvm.org/t/rfc-global-function-merging/82608.
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
These define the main data structures to represent stable functions and group similar functions in a function map. Serialization is supported in a binary or yaml form. Depends on llvm#112638. This is a patch for https://discourse.llvm.org/t/rfc-global-function-merging/82608.
kyulee-com
added a commit
that referenced
this pull request
Nov 5, 2024
This introduces a new cgdata format for stable function maps. The raw data is embedded in the __llvm_merge section during compile time. This data can be read and merged using the llvm-cgdata tool, into an indexed cgdata file. Consequently, the tool is now capable of handling either outlined hash trees, stable function maps, or both, as they are orthogonal. Depends on #112662. This is a patch for https://discourse.llvm.org/t/rfc-global-function-merging/82608.
PhilippRados
pushed a commit
to PhilippRados/llvm-project
that referenced
this pull request
Nov 6, 2024
This introduces a new cgdata format for stable function maps. The raw data is embedded in the __llvm_merge section during compile time. This data can be read and merged using the llvm-cgdata tool, into an indexed cgdata file. Consequently, the tool is now capable of handling either outlined hash trees, stable function maps, or both, as they are orthogonal. Depends on llvm#112662. This is a patch for https://discourse.llvm.org/t/rfc-global-function-merging/82608.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These define the main data structures to represent stable functions and group similar functions in a function map.
Serialization is supported in a binary or yaml form.
Depends on #112638.
This is a patch for https://discourse.llvm.org/t/rfc-global-function-merging/82608.