Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoopVectorize] Fix typo in branch-weights.ll test CEHCK->CHECK (NFC) #113574

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

hyongtao-db
Copy link
Contributor

Fix the typo CEHCK

Signed-off-by: Yongtao Huang yongtaoh2022@gmail.com

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Member

llvmbot commented Oct 24, 2024

@llvm/pr-subscribers-llvm-transforms

Author: Yongtao Huang (hyongtao-db)

Changes

Fix the typo CEHCK

Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>


Full diff: https://github.com/llvm/llvm-project/pull/113574.diff

1 Files Affected:

  • (modified) llvm/test/Transforms/LoopVectorize/branch-weights.ll (+2-2)
diff --git a/llvm/test/Transforms/LoopVectorize/branch-weights.ll b/llvm/test/Transforms/LoopVectorize/branch-weights.ll
index cf96469bc97b94..db2c8188a7cb35 100644
--- a/llvm/test/Transforms/LoopVectorize/branch-weights.ll
+++ b/llvm/test/Transforms/LoopVectorize/branch-weights.ll
@@ -75,8 +75,8 @@ exit:
 
 ; CHECK: [[PROF_F0_ENTRY]] = !{!"branch_weights", i32 12, i32 1}
 ; CHECK: [[PROF_F0_UNLIKELY]] = !{!"branch_weights", i32 1, i32 127}
-; CEHCK: [[PROF_F0_VECTOR_BODY]] = !{!"branch_weights", i32 1, i32 307}
+; CHECK: [[PROF_F0_VECTOR_BODY]] = !{!"branch_weights", i32 1, i32 307}
 ; CHECK: [[PROF_F0_MIDDLE_BLOCKS]] =  !{!"branch_weights", i32 1, i32 3}
 ; CHECK: [[PROF_F0_VEC_EPILOGUE_SKIP]] = !{!"branch_weights", i32 4, i32 0}
 ; CHECK: [[PROF_F0_VEC_EPILOG_VECTOR_BODY]] = !{!"branch_weights", i32 0, i32 0}
-; CEHCK: [[PROF_F0_LOOP]] = !{!"branch_weights", i32 2, i32 1}
+; CHECK: [[PROF_F0_LOOP]] = !{!"branch_weights", i32 2, i32 1}

@cjappl cjappl requested a review from MatzeB October 24, 2024 19:42
@cjappl cjappl changed the title Fix typo [LLVM] Fix typo in branch-weights.ll test CEHCK->CHECK Oct 24, 2024
@cjappl
Copy link
Contributor

cjappl commented Oct 24, 2024

Requesting review from @MatzeB as the original person who committed this change.

This fix seems reasonable to me, but I want to make sure it wasn't intentionally disabled for some reason

@Enna1 Enna1 requested a review from nikic October 25, 2024 11:48
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikic nikic changed the title [LLVM] Fix typo in branch-weights.ll test CEHCK->CHECK [LoopVectorize] Fix typo in branch-weights.ll test CEHCK->CHECK (NFC) Nov 5, 2024
@nikic nikic merged commit f6948e8 into llvm:main Nov 5, 2024
8 of 10 checks passed
Copy link

github-actions bot commented Nov 5, 2024

@hyongtao-db Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@hyongtao-db hyongtao-db deleted the fix-typo branch November 5, 2024 15:41
PhilippRados pushed a commit to PhilippRados/llvm-project that referenced this pull request Nov 6, 2024
…llvm#113574)

Fix the typo CEHCK.

Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants