Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PassBuilder] Replace bool LTOPreLink with ThinOrFullLTOPhase Phase #114564

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

shiltian
Copy link
Contributor

@shiltian shiltian commented Nov 1, 2024

This will allow more fine-grained control in the future.

Copy link
Contributor Author

shiltian commented Nov 1, 2024

Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

llvm/lib/Passes/PassBuilderPipelines.cpp Outdated Show resolved Hide resolved
llvm/lib/Passes/PassBuilderPipelines.cpp Outdated Show resolved Hide resolved
This will allow more fine-grained control in the future.
@shiltian shiltian force-pushed the users/shiltian/bool-to-phase branch from c271a32 to 8f36cd9 Compare November 1, 2024 17:12
@shiltian shiltian merged commit 5445edb into main Nov 1, 2024
6 of 8 checks passed
@shiltian shiltian deleted the users/shiltian/bool-to-phase branch November 1, 2024 18:56
@llvm-ci
Copy link
Collaborator

llvm-ci commented Nov 1, 2024

LLVM Buildbot has detected a new failure on builder clang-cmake-x86_64-avx512-linux running on avx512-intel64 while building llvm at step 12 "setup lit".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/133/builds/6101

Here is the relevant piece of the build log for the reference
Step 12 (setup lit) failure: '/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/bin/python /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/lnt/setup.py ...' (failure)
...

Installed /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/lib64/python3.9/site-packages/typing-3.10.0.0-py3.9.egg
Searching for Flask-WTF==0.12
Reading https://pypi.org/simple/Flask-WTF/
Downloading https://files.pythonhosted.org/packages/f6/fe/9fe6a8a4edcc39f8ec365dc16d292d659f7a77a0ed596947f29c0c5c9dc1/Flask-WTF-0.12.tar.gz#sha256=bd99316c97ed1d1cb90b8f0c242c86420a891a6a2058f20717e424bf5b0bb80e
Best match: Flask-WTF 0.12
Processing Flask-WTF-0.12.tar.gz
Writing /tmp/easy_install-c6kj_ut_/Flask-WTF-0.12/setup.cfg
Running Flask-WTF-0.12/setup.py -q bdist_egg --dist-dir /tmp/easy_install-c6kj_ut_/Flask-WTF-0.12/egg-dist-tmp-qlhz4jzb
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/lib/python3.9/site-packages/setuptools/_distutils/dist.py:261: UserWarning: Unknown distribution option: 'test_suite'
  warnings.warn(msg)
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/lib/python3.9/site-packages/setuptools/_distutils/dist.py:261: UserWarning: Unknown distribution option: 'tests_require'
  warnings.warn(msg)
warning: no previously-included files matching '*.pyc' found under directory 'tests'
warning: no previously-included files matching '*.pyc' found under directory 'tests'
warning: no previously-included files matching '*.pyc' found under directory 'docs'
warning: no previously-included files matching '*.pyo' found under directory 'docs'
no previously-included directories found matching 'docs/_build'
no previously-included directories found matching 'docs/_themes/.git'
/localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/lib/python3.9/site-packages/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated.
!!

        ********************************************************************************
        Please avoid running ``setup.py`` directly.
        Instead, use pypa/build, pypa/installer or other
        standards-based tools.

        See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
        ********************************************************************************

!!
  self.initialize_options()
Adding Flask-WTF 0.12 to easy-install.pth file
detected new path './typing-3.10.0.0-py3.9.egg'

Installed /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/lib64/python3.9/site-packages/Flask_WTF-0.12-py3.9.egg
Searching for WTForms==2.0.2
Reading https://pypi.org/simple/WTForms/
Downloading https://files.pythonhosted.org/packages/6f/eb/516497dcf86fde90f68b64768b2258ab7a2c92ee00159fc7cf978465ef05/WTForms-2.0.2-py2.py3-none-any.whl#sha256=da3a39b57460c88539cb4eb3e36aa2946aa7ce4dfaa01ccd2a23f47f70a1b5de
Best match: WTForms 2.0.2
Processing WTForms-2.0.2-py2.py3-none-any.whl
Installing WTForms-2.0.2-py2.py3-none-any.whl to /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/lib64/python3.9/site-packages
Adding WTForms 2.0.2 to easy-install.pth file
detected new path './Flask_WTF-0.12-py3.9.egg'

Installed /localdisk2/buildbot/llvm-worker/clang-cmake-x86_64-avx512-linux/test/sandbox/lib64/python3.9/site-packages/WTForms-2.0.2-py3.9.egg
Searching for pytz==2016.10
Reading https://pypi.org/simple/pytz/
Downloading https://files.pythonhosted.org/packages/f5/fa/4a9aefc206aa49a4b5e0a72f013df1f471b4714cdbe6d78f0134feeeecdb/pytz-2016.10-py2.py3-none-any.whl#sha256=a1ea35e87a63c7825846d5b5c81d23d668e8a102d3b1b465ce95afe1b3a2e065
error: Download error for https://files.pythonhosted.org/packages/f5/fa/4a9aefc206aa49a4b5e0a72f013df1f471b4714cdbe6d78f0134feeeecdb/pytz-2016.10-py2.py3-none-any.whl#sha256=a1ea35e87a63c7825846d5b5c81d23d668e8a102d3b1b465ce95afe1b3a2e065: [Errno -2] Name or service not known

smallp-o-p pushed a commit to smallp-o-p/llvm-project that referenced this pull request Nov 3, 2024
…e` (llvm#114564)

This will allow more fine-grained control in the future.
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
…e` (llvm#114564)

This will allow more fine-grained control in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants