-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLIR] Fix a stack-use-after-scope error in OpFormatGen.cpp #114789
Conversation
@llvm/pr-subscribers-mlir-core Author: Haojian Wu (hokein) ChangesFull diff: https://github.com/llvm/llvm-project/pull/114789.diff 1 Files Affected:
diff --git a/mlir/tools/mlir-tblgen/OpFormatGen.cpp b/mlir/tools/mlir-tblgen/OpFormatGen.cpp
index 3bf6f2f6d38176..7e2b0694a860a3 100644
--- a/mlir/tools/mlir-tblgen/OpFormatGen.cpp
+++ b/mlir/tools/mlir-tblgen/OpFormatGen.cpp
@@ -229,10 +229,9 @@ class OIListElement : public DirectiveElementBase<DirectiveElement::OIList> {
/// Returns a range to iterate over the LiteralElements.
auto getLiteralElements() const {
- function_ref<LiteralElement *(FormatElement * el)>
- literalElementCastConverter =
- [](FormatElement *el) { return cast<LiteralElement>(el); };
- return llvm::map_range(literalElements, literalElementCastConverter);
+ return llvm::map_range(literalElements, [](FormatElement *el) {
+ return cast<LiteralElement>(el);
+ });
}
/// Returns a range to iterate over the parsing elements corresponding to the
|
@llvm/pr-subscribers-mlir Author: Haojian Wu (hokein) ChangesFull diff: https://github.com/llvm/llvm-project/pull/114789.diff 1 Files Affected:
diff --git a/mlir/tools/mlir-tblgen/OpFormatGen.cpp b/mlir/tools/mlir-tblgen/OpFormatGen.cpp
index 3bf6f2f6d38176..7e2b0694a860a3 100644
--- a/mlir/tools/mlir-tblgen/OpFormatGen.cpp
+++ b/mlir/tools/mlir-tblgen/OpFormatGen.cpp
@@ -229,10 +229,9 @@ class OIListElement : public DirectiveElementBase<DirectiveElement::OIList> {
/// Returns a range to iterate over the LiteralElements.
auto getLiteralElements() const {
- function_ref<LiteralElement *(FormatElement * el)>
- literalElementCastConverter =
- [](FormatElement *el) { return cast<LiteralElement>(el); };
- return llvm::map_range(literalElements, literalElementCastConverter);
+ return llvm::map_range(literalElements, [](FormatElement *el) {
+ return cast<LiteralElement>(el);
+ });
}
/// Returns a range to iterate over the parsing elements corresponding to the
|
I just tweaked the title, hopefully it makes sense. Thanks for the fix! |
Make senses, thanks for the prompt review. |
No description provided.