[libc++] Remove <string> and <vector> includes from <flat_map> #114876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Nikolas Klauser (philnik777) Changes
Full diff: https://github.com/llvm/llvm-project/pull/114876.diff 1 Files Affected:
diff --git a/libcxx/include/__flat_map/flat_map.h b/libcxx/include/__flat_map/flat_map.h
index 5c14c0ac693b08..dbab5425065f46 100644
--- a/libcxx/include/__flat_map/flat_map.h
+++ b/libcxx/include/__flat_map/flat_map.h
@@ -19,6 +19,7 @@
#include <__algorithm/ranges_stable_sort.h>
#include <__algorithm/ranges_unique.h>
#include <__algorithm/ranges_upper_bound.h>
+#include <__algorithm/remove_if.h>
#include <__compare/synth_three_way.h>
#include <__concepts/convertible_to.h>
#include <__concepts/swappable.h>
@@ -52,10 +53,9 @@
#include <__type_traits/maybe_const.h>
#include <__utility/exception_guard.h>
#include <__utility/pair.h>
+#include <__vector/vector.h>
#include <initializer_list>
#include <stdexcept>
-#include <string>
-#include <vector>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header
|
ldionne
approved these changes
Nov 4, 2024
philnik777
force-pushed
the
flat_map_remove_includes
branch
2 times, most recently
from
4cdd5b3 to
ecb1593
Compare
philnik777
force-pushed
the
flat_map_remove_includes
branch
from
ecb1593 to
d6a7b1b
Compare
rampitec
pushed a commit
that referenced
this pull request
Nov 5, 2024
`<string>` doesn't seem to be required at all and `flat_map` doesn't support `vector<bool>`, so we can include just `vector<T>`. This cuts the include time in half on my system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<string>doesn't seem to be required at all andflat_mapdoesn't supportvector<bool>, so we can include justvector<T>. This cuts the include time in half on my system.