Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb] Relax check for breakpoint site in Unwind/windows-unaligned-x86_64.test #115318

Conversation

weliveindetail
Copy link
Contributor

This test checks the thread backtrace for entries of intermediate frames that aren't aligned to 16 bytes. In order to do that, it sets a single breakpoint and makes sure we stop there. It seems sufficient, however, to check that we hit the breakpoint itself and not which particular site.

@weliveindetail
Copy link
Contributor Author

weliveindetail commented Nov 7, 2024

We see a few tests failing for this reason downstream in swift-lldb: swiftlang/swift#76894 (comment) I filed a ticket to investigate the actual issue swiftlang#9540

It would be great to unblock this particular test, because we expect the functionality under test to be fixed with #106686

@weliveindetail weliveindetail marked this pull request as ready for review November 13, 2024 12:58
@llvmbot llvmbot added the lldb label Nov 13, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 13, 2024

@llvm/pr-subscribers-lldb

Author: Stefan Gränitz (weliveindetail)

Changes

This test checks the thread backtrace for entries of intermediate frames that aren't aligned to 16 bytes. In order to do that, it sets a single breakpoint and makes sure we stop there. It seems sufficient, however, to check that we hit the breakpoint itself and not which particular site.


Full diff: https://github.com/llvm/llvm-project/pull/115318.diff

1 Files Affected:

  • (modified) lldb/test/Shell/Unwind/windows-unaligned-x86_64.test (+1-1)
diff --git a/lldb/test/Shell/Unwind/windows-unaligned-x86_64.test b/lldb/test/Shell/Unwind/windows-unaligned-x86_64.test
index 94f1c011ebd2a6..0356960424328b 100644
--- a/lldb/test/Shell/Unwind/windows-unaligned-x86_64.test
+++ b/lldb/test/Shell/Unwind/windows-unaligned-x86_64.test
@@ -17,7 +17,7 @@ breakpoint set -n func
 # CHECK: Breakpoint 1: where = {{.*}}`{{(::)?}}func
 
 process launch
-# CHECK: stop reason = breakpoint 1.1
+# CHECK: stop reason = breakpoint 1
 
 thread backtrace
 # CHECK: frame #0: {{.*}}`{{(::)?}}func

@weliveindetail
Copy link
Contributor Author

@mstorsjo Any thoughts/concerns about this?

Copy link
Member

@mstorsjo mstorsjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this seems reasonable - I guess the new form should match both breakpoint 1 and breakpoint 1.1.

@weliveindetail weliveindetail merged commit 1d0b285 into llvm:main Nov 18, 2024
11 checks passed
@weliveindetail weliveindetail deleted the lldb-test-unwind-windows-unaligned-relax-check branch November 19, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants