Skip to content

[flang] Handle duplicate backslashes in preprocessor. #115822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

olee7
Copy link

@olee7 olee7 commented Nov 12, 2024

Fixes:
112604

Fixes the issue where preprocessor will escape the backslashes but the compiler will not re-combine them.

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added flang Flang issues not falling into any other category flang:parser labels Nov 12, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 12, 2024

@llvm/pr-subscribers-flang-parser

Author: Lake (olee7)

Changes

Fixes:
112604

Fixes the issue where preprocessor will escape the backslashes but the compiler will not re-combine them.


Full diff: https://github.com/llvm/llvm-project/pull/115822.diff

2 Files Affected:

  • (modified) flang/lib/Parser/prescan.cpp (+1-1)
  • (added) flang/test/Parser/duplicate-backslashes.f90 (+23)
diff --git a/flang/lib/Parser/prescan.cpp b/flang/lib/Parser/prescan.cpp
index 1d2f1e97668792..8c991678047ecd 100644
--- a/flang/lib/Parser/prescan.cpp
+++ b/flang/lib/Parser/prescan.cpp
@@ -843,7 +843,7 @@ void Prescanner::QuotedCharacterLiteral(
     if (*at_ == '\\') {
       if (escapesEnabled) {
         isEscaped = !isEscaped;
-      } else {
+      } else if (!preprocessingOnly_) {
         // The parser always processes escape sequences, so don't confuse it
         // when escapes are disabled.
         insert('\\');
diff --git a/flang/test/Parser/duplicate-backslashes.f90 b/flang/test/Parser/duplicate-backslashes.f90
new file mode 100644
index 00000000000000..896a5e864bc93d
--- /dev/null
+++ b/flang/test/Parser/duplicate-backslashes.f90
@@ -0,0 +1,23 @@
+! RUN: %flang -cpp -E %s -o %t.f90
+! RUN: %flang %t.f90 -o %t
+! RUN: %t | FileCheck %s
+
+program main
+  implicit none
+
+  ! Test single backslash
+  write(*, '(A)') "\"   ! Expected single backslash in output
+  ! CHECK: \
+  ! CHECK-NOT: \\
+
+  ! Test double backslash
+  write(*, '(A)') "\\"   ! Expected double backslashes in output
+  ! CHECK: \\
+  ! CHECK-NOT: \\\\
+
+  ! Test quadruple backslash
+  write(*, '(A)') "\\\\"   ! Expected quadruple backslashes in output
+  ! CHECK: \\\\
+  ! CHECK-NOT: \\\\\\\\
+
+end program main

@olee7 olee7 marked this pull request as draft November 12, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:parser flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants