Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc++] Fix CI issues recently introduced by localization changes #116216

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Nov 14, 2024

After a recent Github Actions runner policy change 1, the version of Xcode included in
the macos-14 image went from Xcode 16 to Xcode 15, breaking our build bots.

This moves the bots to the macos 15 (public preview) image, which contains Xcode 16.

Also, adjust an UNSUPPORTED annotation that was incorrectly targeting macos 13.7
when it should have been targeting a version of AppleClang.

@ldionne ldionne marked this pull request as ready for review November 14, 2024 22:57
@ldionne ldionne requested a review from a team as a code owner November 14, 2024 22:57
@ldionne
Copy link
Member Author

ldionne commented Nov 14, 2024

Merging since this passed CI based on previous runs when this was a draft, and this is currently failing all macOS jobs.

@ldionne ldionne merged commit 2d6459c into llvm:main Nov 14, 2024
9 of 12 checks passed
@ldionne ldionne deleted the review/fix-macos-ci branch November 14, 2024 23:00
@ldionne
Copy link
Member Author

ldionne commented Nov 14, 2024

I guess this was merged with a proper commit message but an incorrect title, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant