Skip to content

[clang-repl] Use default visibility for symbols while building CompilerInstance against emscripten #116779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[clang-repl] Use default visibility for symbols while building CompilerInstance against emscripten #116779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
616ebd6
Use default visibility for symbols while building CompilerInstance ag…
anutosh491 Nov 19, 2024
fedc699
Update Interpreter.cpp
anutosh491 Nov 19, 2024
4001aa3
Merge branch 'main' into wasm-3
anutosh491 Nov 19, 2024
4f05817
fix cleanUp
anutosh491 Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/lib/Interpreter/Interpreter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ IncrementalCompilerBuilder::CreateCpp() {
Argv.push_back("-target");
Argv.push_back("wasm32-unknown-emscripten");
Argv.push_back("-shared");
Argv.push_back("-fvisibility=default");
#endif
Argv.insert(Argv.end(), UserArgs.begin(), UserArgs.end());

Expand Down
3 changes: 1 addition & 2 deletions clang/lib/Interpreter/Wasm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ llvm::Error WasmIncrementalExecutor::addModule(PartialTranslationUnit &PTU) {
"-shared",
"--import-memory",
"--no-entry",
"--export-all",
"--experimental-pic",
"--stack-first",
"--allow-undefined",
Expand Down Expand Up @@ -109,7 +108,7 @@ llvm::Error WasmIncrementalExecutor::runCtors() const {
return llvm::Error::success();
}

llvm::Error WasmIncrementalExecutor::cleanUp() const {
llvm::Error WasmIncrementalExecutor::cleanUp() {
// Can't call cleanUp through IncrementalExecutor as it
// tries to deinitialize JIT which hasn't been initialized
return llvm::Error::success();
Expand Down
Loading