Add release note for parallel module creation in LLDB #116857
Conversation
JDevlieghere
requested review from
DavidSpickett,
adrian-prantl and
jasonmolenda
Release note llvm#110646 and llvm#114507.
JDevlieghere
force-pushed
the
parallel-module-release-note
branch
from
942deda to
4dafd39
Compare
llvm/docs/ReleaseNotes.md
Outdated
| @@ -355,6 +355,8 @@ Changes to LLDB | |||
|
|
|||
| * A new setting `target.launch-working-dir` can be used to set a persistent cwd that is used by default by `process launch` and `run`. | |||
|
|
|||
| * LLDB now creates modules in parallel, resulting in an average 2x speedup when launching and attaching. | |||
There was a problem hiding this comment.
Good idea to highlight it.
Outside of us, I don't think most people know what "creates modules" is. Maybe "reads binaries". More accurately "scans binary symbol tables", but that's pushing what people would understand again.
I do have a little concern that we've only done this for the attach use-case on Darwin, and for the "load all dependent libraries" use case on all platforms. Someone might attach to a process on linux and see no benefit at all, and be sad.
There was a problem hiding this comment.
WDYT of the new wording?
There was a problem hiding this comment.
So is this does load in parallel everywhere but you only measured it on Darwin, or has the possibility to do so everywhere but only does so right now on Darwin?
The former I would write as:
- LLDB can . On Darwin this has resulted in...
Implying that YMMV anywhere else.
The latter:
- LLDB running on Darwin will now load libraries in parallel when attaching or.... This gives an average 2x speedup.
There was a problem hiding this comment.
We load modules in parallel everywhere when launching. We only load modules in parallel when attaching on Darwin (because that happens in our dynamic loader plugin). Linux and other platforms could probably/likely do the same thing, but I haven't looked into it. The improvements are the same regardless of whether the attach or launch.
|
Assuming I remember, I will trawl the git log prior to the 20 branch and see if there's anything release note worthy. But in the meantime glad to see more being added. |
Release note #110646 and #114507.