Populate the llvm::GlobalVariable ELF section, with the attribute from the ObjectAttrs

[Renaud-K]

No description provided.

[llvmbot]

@llvm/pr-subscribers-mlir-gpu
@llvm/pr-subscribers-mlir-llvm

@llvm/pr-subscribers-mlir

Author: Renaud Kauffmann (Renaud-K)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/117246.diff

1 Files Affected:

• (modified) mlir/lib/Target/LLVMIR/Dialect/GPU/SelectObjectAttr.cpp (+7)

diff --git a/mlir/lib/Target/LLVMIR/Dialect/GPU/SelectObjectAttr.cpp b/mlir/lib/Target/LLVMIR/Dialect/GPU/SelectObjectAttr.cpp
index b023c4c126da30..3aeadeb283ff69 100644
--- a/mlir/lib/Target/LLVMIR/Dialect/GPU/SelectObjectAttr.cpp
+++ b/mlir/lib/Target/LLVMIR/Dialect/GPU/SelectObjectAttr.cpp
@@ -121,6 +121,13 @@ LogicalResult SelectObjectAttrImpl::embedBinary(
       new llvm::GlobalVariable(*module, binary->getType(), true,
                                llvm::GlobalValue::LinkageTypes::InternalLinkage,
                                binary, getBinaryIdentifier(op.getName()));
+
+  if (object.getProperties()) {
+    if (auto section = mlir::dyn_cast_or_null<mlir::StringAttr>(
+            object.getProperties().get("section"))) {
+      serializedObj->setSection(section.getValue());
+    }
+  }
   serializedObj->setLinkage(llvm::GlobalValue::LinkageTypes::InternalLinkage);
   serializedObj->setAlignment(llvm::MaybeAlign(8));
   serializedObj->setUnnamedAddr(llvm::GlobalValue::UnnamedAddr::None);

[clementval]

Do we have a way to have a lit test for it?

[Renaud-K]

Populating it would only happen downstream, so I am not sure how we would write a test for it.

[clementval]

Populating it would only happen downstream, so I am not sure how we would write a test for it.

Maybe you can add smth here mlir/test/Target/LLVMIR/gpu.mlir with a pre-populated section.

[Renaud-K]

I see. Nice.

[clementval]

I see. Nice.

Thanks Renaud! This look good to me.

[krzysz00]

Approved, thanks!