Skip to content

[TTI][RISCV] Deduplicate type-based VP costing of vpcmp/vpcast #117520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[TTI][RISCV] Deduplicate type-based VP costing of vpcmp/vpcast #117520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions llvm/include/llvm/CodeGen/BasicTTIImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1618,6 +1618,21 @@ class BasicTTIImplBase : public TargetTransformInfoImplCRTPBase<T> {
return thisT()->getArithmeticInstrCost(*FOp, ICA.getReturnType(),
CostKind);
}
if (VPCastIntrinsic::isVPCast(ICA.getID())) {
return thisT()->getCastInstrCost(
*FOp, ICA.getReturnType(), ICA.getArgTypes()[0],
TTI::CastContextHint::None, CostKind);
}
if (VPCmpIntrinsic::isVPCmp(ICA.getID())) {
// We can only handle vp_cmp intrinsics with underlying instructions.
if (ICA.getInst()) {
assert(FOp);
auto *UI = cast<VPCmpIntrinsic>(ICA.getInst());
return thisT()->getCmpSelInstrCost(*FOp, ICA.getArgTypes()[0],
ICA.getReturnType(),
UI->getPredicate(), CostKind);
}
}
}

std::optional<Intrinsic::ID> FID =
Expand Down
33 changes: 0 additions & 33 deletions llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,39 +1113,6 @@ RISCVTTIImpl::getIntrinsicInstrCost(const IntrinsicCostAttributes &ICA,
return getArithmeticInstrCost(*FOp, ICA.getReturnType(), CostKind);
break;
}
// vp int cast ops.
case Intrinsic::vp_trunc:
case Intrinsic::vp_zext:
case Intrinsic::vp_sext:
// vp float cast ops.
case Intrinsic::vp_fptoui:
case Intrinsic::vp_fptosi:
case Intrinsic::vp_uitofp:
case Intrinsic::vp_sitofp:
case Intrinsic::vp_fptrunc:
case Intrinsic::vp_fpext: {
std::optional<unsigned> FOp =
VPIntrinsic::getFunctionalOpcodeForVP(ICA.getID());
assert(FOp.has_value() && !ICA.getArgTypes().empty());
return getCastInstrCost(*FOp, RetTy, ICA.getArgTypes()[0],
TTI::CastContextHint::None, CostKind);
break;
}

// vp compare
case Intrinsic::vp_icmp:
case Intrinsic::vp_fcmp: {
Intrinsic::ID IID = ICA.getID();
std::optional<unsigned> FOp = VPIntrinsic::getFunctionalOpcodeForVP(IID);
// We can only handle vp_cmp intrinsics with underlying instructions.
if (!ICA.getInst())
break;

assert(FOp);
auto *UI = cast<VPCmpIntrinsic>(ICA.getInst());
return getCmpSelInstrCost(*FOp, ICA.getArgTypes()[0], ICA.getReturnType(),
UI->getPredicate(), CostKind);
}
case Intrinsic::vp_select: {
Intrinsic::ID IID = ICA.getID();
std::optional<unsigned> FOp = VPIntrinsic::getFunctionalOpcodeForVP(IID);
Expand Down
Loading