wip: [DirectX] Refactor resources into binding and type passes #119738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
This is a big refactor of resources into two separate passes (llvm#118400), which also happens to fix llvm#116849. Unfortunately it's quite large and probably not practical to review. I plan on splitting this into three changes: 1. Rework resource type info to work by accessing the target ext type 2. Introduce the resource type analysis pass 3. Add and use the createSymbol API
bogner
force-pushed
the
2024-12-12-resource-passes
branch
from
eed6eef to
4838618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big refactor of resources into two separate passes (#118400), which also happens to fix #116849. Unfortunately it's quite large and probably not practical to review.
I plan on splitting this into three changes: