Skip to content

[LLVM] Update maintainers for binary utilities #120428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Dec 18, 2024

See developer policy for context on the maintainers terminology.

We currently list @jakehehrlich as the maintainer for llvm-objcopy / ObjCopy, but he hasn't been involved with LLVM for more than 5 years.

Looking through the contribution history it's not very obvious who to nominate as a replacement here, but I think @MaskRay is the main person with regular contributions in this area.

@nikic nikic requested a review from MaskRay December 18, 2024 14:01
@MaskRay
Copy link
Member

MaskRay commented Dec 18, 2024

llvm-objcopy is a stable, largely mature drop-in replacement for GNU objcopy, including LLVM extensions.
It is so stable that it doesn't receive much active development.

I suggest that we replace the specific tool llvm-objcopy/ObjCopy with the broader "LLVM binary utilities".
(In addition, we have a llvm:binary-utilities new PR label, but not for llvm-objcopy.)

@jh7370 has been the most active reviewer in this area, so I'd like to nominate him as well.
(As we allow multiple maintainers, you may name both of us.)
While James might be less active in patch contribution, his provides invaluable code review, which is essential to catch potential issues and ensure code maintainability

@nikic
Copy link
Contributor Author

nikic commented Dec 18, 2024

llvm-objcopy is a stable, largely mature drop-in replacement for GNU objcopy, including LLVM extensions. It is so stable that it doesn't receive much active development.

I suggest that we replace the specific tool llvm-objcopy/ObjCopy with the broader "LLVM binary utilities". (In addition, we have a llvm:binary-utilities new PR label, but not for llvm-objcopy.)

Thanks, that makes a lot of sense.

@jh7370 has been the most active reviewer in this area, so I'd like to nominate him as well. (As we allow multiple maintainers, you may name both of us.) While James might be less active in patch contribution, his provides invaluable code review, which is essential to catch potential issues and ensure code maintainability

Thanks for pointing that out, I've added @jh7370 now! Unfortunately GitHub only makes it easy to find people who often commit to an area, but not people who often review :(

@nikic nikic changed the title [LLVM] Update llvm-objcopy maintainer [LLVM] Update maintainers for binary utilities Dec 18, 2024
@nikic nikic requested a review from jh7370 December 18, 2024 17:35
Copy link
Member

@MaskRay MaskRay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@jh7370 jh7370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to accept this myself.

There are a handful of what some people will consider "binary utilities" that I don't contribute to (i.e. review), but I think this is a reasonable thing nonetheless.

@nikic nikic force-pushed the objcopy-maintainer branch 2 times, most recently from 1dd806b to e3f6a4c Compare December 19, 2024 08:28
@nikic nikic force-pushed the objcopy-maintainer branch from e3f6a4c to 7e29994 Compare December 19, 2024 08:29
@nikic nikic merged commit 881447f into llvm:main Dec 19, 2024
5 of 7 checks passed
@nikic nikic deleted the objcopy-maintainer branch December 19, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants