[clang][test] Fix -DBUILD_SHARED_LIBS build by adding depency on Targ… #130105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etParser from clangTesting Commit 979c275 (llvm#129868) introduced a dependency on the llvm::Triple::Triple in `lookupTarget`. This is part of TargetParser, which wasn't listed in clang/lib/Testing/CMakeLists.txt. This broke the -DBUILD_SHARED_LIBS=True builds.
|
@llvm/pr-subscribers-clang Author: Kito Cheng (kito-cheng) Changes…etParser from clangTesting Commit 979c275 (#129868) introduced a dependency on the llvm::Triple::Triple in Full diff: https://github.com/llvm/llvm-project/pull/130105.diff 1 Files Affected:
diff --git a/clang/lib/Testing/CMakeLists.txt b/clang/lib/Testing/CMakeLists.txt
index 4a2400d6a107a..f4c99413d6dbf 100644
--- a/clang/lib/Testing/CMakeLists.txt
+++ b/clang/lib/Testing/CMakeLists.txt
@@ -13,6 +13,7 @@ add_llvm_library(clangTesting
LINK_COMPONENTS
MC
Support
+ TargetParser
)
clang_target_link_libraries(clangTesting
|
nikic
approved these changes
Mar 6, 2025
|
Tests pass, ok to merge @nikic @kito-cheng ? |
VishMCW
pushed a commit
to VishMCW/llvm-project
that referenced
this pull request
Mar 18, 2025
llvm#130105) …etParser from clangTesting Commit 979c275 (llvm#129868) introduced a dependency on the llvm::Triple::Triple in `lookupTarget`. This is part of TargetParser, which wasn't listed in clang/lib/Testing/CMakeLists.txt. This broke the -DBUILD_SHARED_LIBS=True builds. Fixes llvm#130112
jph-13
pushed a commit
to jph-13/llvm-project
that referenced
this pull request
Mar 21, 2025
llvm#130105) …etParser from clangTesting Commit 979c275 (llvm#129868) introduced a dependency on the llvm::Triple::Triple in `lookupTarget`. This is part of TargetParser, which wasn't listed in clang/lib/Testing/CMakeLists.txt. This broke the -DBUILD_SHARED_LIBS=True builds. Fixes llvm#130112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etParser from clangTesting
Commit 979c275 (#129868) introduced a dependency on the llvm::Triple::Triple in
lookupTarget. This is part of TargetParser, which wasn't listed in clang/lib/Testing/CMakeLists.txt. This broke the -DBUILD_SHARED_LIBS=True builds.Fixes #130112