-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Refactor generate_test_report script #133196
[CI] Refactor generate_test_report script #133196
Conversation
Created using spr 1.3.4
This patch refactors the generate_test_report script, namely turning it into a proper library, and pulling the script/unittests out into separate files, as is standard with most python scripts. The main purpose of this is to enable reusing the library for the new Github premerge. Pull Request: llvm#133196
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I was thinking why don't you have the same entry point for GitHub and Buildkite as for now, the only difference would be that the environment variables wouldn't be set.
But that is not the only difference, in buildkite there is an agent to send the report to. There is not in Github.
So I like splitting this so you can have a GitHub entry point, as you do in the follow up PR.
(and btw, don't feel the need to keep any of this code if it would be easier to junk it and use something custom or a built-in GitHub feature if you find one)
This patch refactors the generate_test_report script, namely turning it into a proper library, and pulling the script/unittests out into separate files, as is standard with most python scripts. The main purpose of this is to enable reusing the library for the new Github premerge. Pull Request: llvm#133196
Created using spr 1.3.4
Created using spr 1.3.4
This patch refactors the generate_test_report script, namely turning it into a proper library, and pulling the script/unittests out into separate files, as is standard with most python scripts. The main purpose of this is to enable reusing the library for the new Github premerge. Pull Request: llvm#133196
For now this seems like the path of least resistance. We could do things a bit nicer in Github, but there are tradeoffs, mainly with parallelism if we want to split the job into multiple steps that each invoke their own test targets. |
This patch refactors the generate_test_report script, namely turning it into a proper library, and pulling the script/unittests out into separate files, as is standard with most python scripts. The main purpose of this is to enable reusing the library for the new Github premerge. Reviewers: tstellar, DavidSpickett, Keenuts, lnihlen Reviewed By: DavidSpickett Pull Request: llvm/llvm-project#133196
This patch refactors the generate_test_report script, namely turning it
into a proper library, and pulling the script/unittests out into
separate files, as is standard with most python scripts. The main
purpose of this is to enable reusing the library for the new Github
premerge.