[lldb][lldb-dap] explicitly set the expr as an alias for expression.

[da-viper]

dap console does not recognise expr as a command because it is not explicitly set.

It works fine in normal lldb because it is gotten from approximate match which is not available in the SBAPI

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Ebuka Ezike (da-viper)

Changes

dap console does not recognise expr as a command because it is not explicitly set.

It works fine in normal lldb because it is gotten from approximate match which is not available in the SBAPI

---

Full diff: https://github.com/llvm/llvm-project/pull/134562.diff

1 Files Affected:

• (modified) lldb/source/Interpreter/CommandInterpreter.cpp (+4-1)

diff --git a/lldb/source/Interpreter/CommandInterpreter.cpp b/lldb/source/Interpreter/CommandInterpreter.cpp
index 112d2f20fda41..a4071f5f0a602 100644
--- a/lldb/source/Interpreter/CommandInterpreter.cpp
+++ b/lldb/source/Interpreter/CommandInterpreter.cpp
@@ -444,6 +444,7 @@ void CommandInterpreter::Initialize() {
   if (cmd_obj_sp) {
     // Ensure `e` runs `expression`.
     AddAlias("e", cmd_obj_sp);
+    AddAlias("expr", cmd_obj_sp);
     AddAlias("call", cmd_obj_sp, "--")->SetHelpLong("");
     CommandAlias *parray_alias =
         AddAlias("parray", cmd_obj_sp, "--element-count %1 --");
@@ -1376,7 +1377,9 @@ bool CommandInterpreter::GetAliasFullName(llvm::StringRef cmd,
 }
 
 bool CommandInterpreter::AliasExists(llvm::StringRef cmd) const {
-  return m_alias_dict.find(cmd) != m_alias_dict.end();
+  std::string alias_name;
+  return GetAliasFullName(cmd, alias_name);
+  // return m_alias_dict.find(cmd) != m_alias_dict.end();
 }
 
 bool CommandInterpreter::UserCommandExists(llvm::StringRef cmd) const {

[jimingham]

The lldb command line was designed so that it always does shortest complete match, and there are a lot of common commands that people only type partially. Adding one more expr alias isn't such a big deal, but adding special purpose aliases for all the shortenings people want to use is not supportable (and might collide with other aliases users have set).
So we need a better solution to this DAP problem than just adding aliases.

[da-viper]

Another solution I could think of is prioritising, the repl command type instead of the repl variable type.
in

llvm-project/lldb/tools/lldb-dap/DAP.cpp

Lines 553 to 558 in 4607d39

	// Variables take preference to commands in auto, since commands can always
	// be called using the command_escape_prefix
	return term_is_variable ? ReplMode::Variable
	: term_is_command ? ReplMode::Command
	: ReplMode::Variable;
	}

or add the previously defined aliases in docs explicitly as aliases.