OMPIRBuilder: Cleanup checking for GlobalValue

[arsenm]

GlobalValue already subsumes GlobalObject and GlobalVariable,
plus make use of the std::get<0> already copied to a variable
above.

[arsenm]

• OMPIRBuilder: Do not try to expand uses of ConstantData #134584
• OMPIRBuilder: Cleanup checking for GlobalValue #134583 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-flang-openmp

Author: Matt Arsenault (arsenm)

Changes

GlobalValue already subsumes GlobalObject and GlobalVariable,
plus make use of the std::get<0> already copied to a variable
above.

---

Full diff: https://github.com/llvm/llvm-project/pull/134583.diff

1 Files Affected:

• (modified) llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp (+1-3)

diff --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
index 68b1fa42934ad..bbb44288d0d0d 100644
--- a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
+++ b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
@@ -7027,9 +7027,7 @@ static Expected<Function *> createOutlinedFunction(
     // preceding mapped arguments that refer to the same global that may be
     // seperate segments. To prevent this, we defer global processing until all
     // other processing has been performed.
-    if (llvm::isa<llvm::GlobalValue>(std::get<0>(InArg)) ||
-        llvm::isa<llvm::GlobalObject>(std::get<0>(InArg)) ||
-        llvm::isa<llvm::GlobalVariable>(std::get<0>(InArg))) {
+    if (isa<GlobalValue>(Input)) {
       DeferredReplacement.push_back(std::make_pair(Input, InputCopy));
       continue;
     }

[arsenm]

Merge activity

• Apr 7, 8:19 PM EDT: A user started a stack merge that includes this pull request via Graphite.
• Apr 7, 8:22 PM EDT: Graphite rebased this pull request as part of a merge.
• Apr 7, 8:25 PM EDT: Graphite rebased this pull request as part of a merge.
• Apr 7, 8:28 PM EDT: Graphite rebased this pull request as part of a merge.
• Apr 7, 8:31 PM EDT: Graphite rebased this pull request as part of a merge.
• Apr 7, 8:33 PM EDT: A user merged this pull request with Graphite.