Skip to content

[asan] Fix build on fuchsia #136042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

vitalybuka
Copy link
Collaborator

Does not link after #131756

Created using spr 1.3.4
@vitalybuka vitalybuka added skip-precommit-approval PR for CI feedback, not intended for review and removed compiler-rt compiler-rt:asan Address sanitizer compiler-rt:sanitizer labels Apr 16, 2025
@vitalybuka vitalybuka merged commit 7623501 into main Apr 16, 2025
10 of 14 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/asan-fix-build-on-fuchsia branch April 16, 2025 22:04
@llvmbot
Copy link
Member

llvmbot commented Apr 16, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Vitaly Buka (vitalybuka)

Changes

Does not link after #131756


Full diff: https://github.com/llvm/llvm-project/pull/136042.diff

1 Files Affected:

  • (modified) compiler-rt/lib/asan/asan_report.cpp (+2)
diff --git a/compiler-rt/lib/asan/asan_report.cpp b/compiler-rt/lib/asan/asan_report.cpp
index e515f20548c00..8b22aebe7cafc 100644
--- a/compiler-rt/lib/asan/asan_report.cpp
+++ b/compiler-rt/lib/asan/asan_report.cpp
@@ -149,7 +149,9 @@ class ScopedInErrorReport {
     // 2. Subsequent error reporting avoids nested lock acquisition patterns.
     // 3. Eliminates the lock order inversion risk between libdl and ASan's
     //    thread registry.
+#if !SANITIZER_SYMBOLIZER_MARKUP
     Symbolizer::GetOrInit()->GetRefreshedListOfModules();
+#endif
 
     // Make sure the registry and sanitizer report mutexes are locked while
     // we're printing an error report.

@mysterymath
Copy link
Contributor

Thanks!

var-const pushed a commit to ldionne/llvm-project that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-precommit-approval PR for CI feedback, not intended for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants