[lldb] Add Python properties to SBBreakpoint and similar

[kastiglione]

Update SBBreakpoint, SBBreakpointLocation, and SBBreakpointName to add Python properties for many of their getters/setters.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Dave Lee (kastiglione)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/142215.diff

2 Files Affected:

• (modified) lldb/bindings/interface/SBBreakpointExtensions.i (+9)
• (modified) lldb/bindings/interface/SBBreakpointLocationExtensions.i (+13)

diff --git a/lldb/bindings/interface/SBBreakpointExtensions.i b/lldb/bindings/interface/SBBreakpointExtensions.i
index 6bc781a327778..82fc3ab0e7c04 100644
--- a/lldb/bindings/interface/SBBreakpointExtensions.i
+++ b/lldb/bindings/interface/SBBreakpointExtensions.i
@@ -50,6 +50,15 @@ STRING_EXTENSION_OUTSIDE(SBBreakpoint)
         enabled = property(IsEnabled, SetEnabled, doc='''A read/write property that configures whether this breakpoint is enabled or not.''')
         one_shot = property(IsOneShot, SetOneShot, doc='''A read/write property that configures whether this breakpoint is one-shot (deleted when hit) or not.''')
         num_locations = property(GetNumLocations, None, doc='''A read only property that returns the count of locations of this breakpoint.''')
+        auto_continue = property(GetAutoContinue, SetAutoContinue, doc='A read/write property that configures the auto-continue property of this breakpoint.')
+        condition = property(GetCondition, SetCondition, doc='A read/write property that configures the condition of this breakpoint.')
+        hit_count = property(GetHitCount, doc='A read only property that returns the hit count of this breakpoint.')
+        ignore_count = property(GetIgnoreCount, SetIgnoreCount, doc='A read/write property that configures the ignore count of this breakpoint.')
+        queue_name = property(GetQueueName, SetQueueName, doc='A read/write property that configures the queue name criteria of this breakpoint.')
+        target = property(GetTarget, doc='A read only property that returns the target of this breakpoint.')
+        thread_id = property(GetThreadID, SetThreadID, doc='A read/write property that configures the thread id criteria of this breakpoint.')
+        thread_index = property(GetThreadIndex, SetThreadIndex, doc='A read/write property that configures the thread index criteria of this breakpoint.')
+        thread_name = property(GetThreadName, SetThreadName, doc='A read/write property that configures the thread name criteria of this breakpoint.')
     %}
 #endif
 }
diff --git a/lldb/bindings/interface/SBBreakpointLocationExtensions.i b/lldb/bindings/interface/SBBreakpointLocationExtensions.i
index 40027790a5e8d..12c87eb2c0fe6 100644
--- a/lldb/bindings/interface/SBBreakpointLocationExtensions.i
+++ b/lldb/bindings/interface/SBBreakpointLocationExtensions.i
@@ -7,6 +7,19 @@ STRING_EXTENSION_LEVEL_OUTSIDE(SBBreakpointLocation, lldb::eDescriptionLevelFull
     # our own equality operator here
     def __eq__(self, other):
       return not self.__ne__(other)
+
+    addr = property(GetAddress, doc='A read only property that returns the address of this breakpoint location.')
+    auto_continue = property(GetAutoContinue, SetAutoContinue, doc='A read/write property that configures the auto-continue property of this breakpoint location.')
+    breakpoint = property(GetBreakpoint, doc='A read only property that returns the parent breakpoint of this breakpoint location.')
+    condition = property(GetCondition, SetCondition, doc='A read/write property that configures the condition of this breakpoint location.')
+    hit_count = property(GetHitCount, doc='A read only property that returns the hit count of this breakpoint location.')
+    id = property(GetID, doc='A read only property that returns the id of this breakpoint location.')
+    ignore_count = property(GetIgnoreCount, SetIgnoreCount, doc='A read/write property that configures the ignore count of this breakpoint location.')
+    load_addr = property(GetLoadAddress, doc='A read only property that returns the load address of this breakpoint location.')
+    queue_name = property(GetQueueName, SetQueueName, doc='A read/write property that configures the queue name criteria of this breakpoint location.')
+    thread_id = property(GetThreadID, SetThreadID, doc='A read/write property that configures the thread id criteria of this breakpoint location.')
+    thread_index = property(GetThreadIndex, SetThreadIndex, doc='A read/write property that configures the thread index criteria of this breakpoint location.')
+    thread_name = property(GetThreadName, SetThreadName, doc='A read/write property that configures the thread name criteria of this breakpoint location.')
     %}
 #endif
 }

[medismailben]

Cool! Would be nice to change some of the existing tests to make sure these work as expected.

[jimingham]

It would be nice to add a few usages, mostly to make sure somebody doesn't remove them or inadvertently scramble up the property -> Getter/Setter while adding a new one or something.

[JDevlieghere]

LGTM. Can you find a test that uses (some of) the old methods and replace them by the properties so these have some coverage?

Edit: I didn't see the previous comments which suggest the same thing.

[jimingham]

It would be better to add the same properties to the SBBreakpointName that the test failures showed up than to revert that test change. If SBBreakpoint's and SBBreakpointLocations have these properties, SBBreakpoint names should as well.

[jimingham]

Thanks! LGTM