Skip to content

Conversation

@silee2
Copy link
Contributor

@silee2 silee2 commented Jul 11, 2025

Previous PR #147375 failed a couple of builds after merging.
Compile error was reported with gcc 7.5
This PR is #147375 plus the fix for compile error with gcc 7.5

@silee2
Copy link
Contributor Author

silee2 commented Jul 11, 2025

@charithaintc @mshahneo
Can you review the fix d7793e5
And merge this PR?
The rest of the PR has been reviewed and approved under #147375
And please add co-author line at the end of commit message.

Co-authored-by: Artem Kroviakov artem.kroviakov@intel.com

Comment on lines +547 to +552
std::string prefetchCode("");
if (!isPrefetch)
prefetchCode += "P";
funcName = llvm::formatv("_Z{0}{1}PU3AS1viiiDv2_i{2}{3}", funcName.size(),
funcName, prefetchCode, bitWidthId)
.str();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the only diff?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The new PR is on the same branch. With only one new commit.

@mshahneo mshahneo self-requested a review July 11, 2025 17:43
Copy link
Contributor

@mshahneo mshahneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshahneo mshahneo merged commit 0a34309 into llvm:main Jul 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants