worklows/release-binaries: Add Windows release binary builds #150793
Conversation
tstellar
requested review from
boomanaiden154,
c-rhodes,
dyung,
omjavaid,
tru and
zmodem
|
I was finally able to get the script working with help from @zmodem to debug some of the issues. Right now this is x86 only. It may be possible to add aarch64, but we would need to change the build script to reduce the build time in order to fit under the 6 hour timeout. |
zmodem
left a comment
zmodem
left a comment
There was a problem hiding this comment.
Very nice!
Not an expert on the environment that this runs in, but from what I can tell, LGTM.
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Some minor comments, broadly LGTM.
| - name: Collect Variables | ||
| id: vars | ||
| env: | ||
| LLVM_VERSION_FROM_SOURCE: ${{ format('{0}.{1}.{2}', steps.version-from-source.outputs.major, steps.version-from-source.outputs.minor, steps.version-from-source.outputs.patch) }} |
There was a problem hiding this comment.
Might be worth it in a future refactoring to make this an explicit output from the composite workflow.
|
@zmodem I'm planning to merge this before the release/22.x, which means you won't need to manually upload binaries any more. Are you OK with this direction? |
|
Sounds great to me, thanks! |
tstellar
changed the title
4 participants
Windows x86 binaries will now be built and uploaded automatically when a new release is tagged.