[OpenMP] Fix LLVM_ENABLE_PROJECTS=openmp build #151117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
openmp:libomp
madhur13490
reviewed
Jul 31, 2025
| # See https://github.com/llvm/llvm-project/issues/124014 | ||
| if (NOT LLVM_RUNTIMES_BUILD AND "openmp" IN_LIST LLVM_ENABLE_PROJECTS) | ||
| set(LLVM_TREE_AVAILABLE True) | ||
| endif () |
Contributor
There was a problem hiding this comment.
I am not an expert in build infrastructure of OpenMP in LLVM, but if we say the mode is deprecated, then why should we continue making changes in the code and keep supporting it? Let's update the documents and fully deprecate LLVM_ENABLE_PROJECTS=openmp?
Member
Author
There was a problem hiding this comment.
Deprecation is just a notice that it is going to be removed to encourage users to move away from it. Until it really is removed, is should still work (or why would one keep non-working code around?).
kshitijvp
pushed a commit
to kshitijvp/llvm-project
that referenced
this pull request
Jan 9, 2026
The build mode has been deprecated in llvm#136314. According to the deprecation message, it was supposed to be removed in the LLVM 21 release. Each build mode increased the maintanance overhead when failing, such as in llvm#151117. Let's remove it in LLVM 22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set LLVM_TREE_AVAILABLE when not defined after #149871. In particular, the LLVM build tree is obviously available with
add_subdirectory(openmp)from the LLVM build tree itself. Note that this build mode is deprecated since #136314.