Skip to content

[flang][OpenMP] Fix typos in diagnostic messages, NFC #154953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kparzysz merged 2 commits into from
Aug 22, 2025
Merged

[flang][OpenMP] Fix typos in diagnostic messages, NFC #154953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eb56b3
[flang][OpenMP] Fix typos in diagnostic messages, NFC
kparzysz Aug 22, 2025
3acf184
format
kparzysz Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions flang/lib/Semantics/check-omp-structure.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,13 +1198,13 @@ void OmpStructureChecker::Enter(const parser::OpenMPGroupprivate &x) {

if (sym->has<AssocEntityDetails>()) {
context_.SayWithDecl(*sym, arg.source,
"GROUPPRIVATE argument cannot be an an ASSOCIATE name"_err_en_US);
"GROUPPRIVATE argument cannot be an ASSOCIATE name"_err_en_US);
continue;
}
if (auto *obj{sym->detailsIf<ObjectEntityDetails>()}) {
if (obj->IsCoarray()) {
context_.Say(arg.source,
"GROUPPRIVATE argument cannot be an a coarray"_err_en_US);
context_.Say(
arg.source, "GROUPPRIVATE argument cannot be a coarray"_err_en_US);
continue;
}
if (obj->init()) {
Expand All @@ -1215,7 +1215,7 @@ void OmpStructureChecker::Enter(const parser::OpenMPGroupprivate &x) {
}
if (sym->test(Symbol::Flag::InCommonBlock)) {
context_.Say(arg.source,
"GROUPPRIVATE argument cannot be an a member of a common block"_err_en_US);
"GROUPPRIVATE argument cannot be a member of a common block"_err_en_US);
continue;
}
if (!IsCommonBlock(*sym)) {
Expand Down
6 changes: 3 additions & 3 deletions flang/test/Semantics/OpenMP/groupprivate.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ subroutine f00
integer, save :: y
associate (z => y)
block
!ERROR: GROUPPRIVATE argument cannot be an an ASSOCIATE name
!ERROR: GROUPPRIVATE argument cannot be an ASSOCIATE name
!$omp groupprivate(z)
end block
end associate
Expand All @@ -25,7 +25,7 @@ module m01
implicit none
integer :: x, y
common /some_block/ x
!ERROR: GROUPPRIVATE argument cannot be an a member of a common block
!ERROR: GROUPPRIVATE argument cannot be a member of a common block
!$omp groupprivate(x)

contains
Expand All @@ -42,6 +42,6 @@ subroutine f01
module m02
implicit none
integer :: x(10)[*]
!ERROR: GROUPPRIVATE argument cannot be an a coarray
!ERROR: GROUPPRIVATE argument cannot be a coarray
!$omp groupprivate(x)
end module