Skip to content

[webkit.UncountedLambdaCapturesChecker] Ignore DeclRefExpr to a lambda in an no-escape argument #155025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2025
Merged

[webkit.UncountedLambdaCapturesChecker] Ignore DeclRefExpr to a lambda in an no-escape argument #155025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e526eb0
[webkit.UncountedLambdaCapturesChecker] Ignore DeclRefExpr to a lambd…
rniwa Aug 22, 2025
0b90a8b
Add a missing new line at the end of the test
rniwa Aug 22, 2025
7869ff9
Remove the dead code
rniwa Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,14 +232,11 @@ class RawPtrRefLambdaCapturesChecker
if (!Init)
return nullptr;
if (auto *Lambda = dyn_cast<LambdaExpr>(Init)) {
DeclRefExprsToIgnore.insert(DRE);
updateIgnoreList();
return Lambda;
}
TempExpr = dyn_cast<CXXBindTemporaryExpr>(Init->IgnoreParenCasts());
if (!TempExpr)
return nullptr;
updateIgnoreList();
return dyn_cast_or_null<LambdaExpr>(TempExpr->getSubExpr());
return nullptr;
}

void checkCalleeLambda(CallExpr *CE) {
Expand Down
25 changes: 24 additions & 1 deletion clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,4 +448,27 @@ void ranges_for_each(RefCountable* obj) {
obj->method();
++(*static_cast<unsigned*>(item));
});
}
}

class RefCountedObj {
public:
void ref();
void deref();

void call() const;
void callLambda([[clang::noescape]] const WTF::Function<void ()>& callback) const;
void doSomeWork() const;
};

void RefCountedObj::callLambda([[clang::noescape]] const WTF::Function<void ()>& callback) const
{
callback();
}

void RefCountedObj::call() const
{
auto lambda = [&] {
doSomeWork();
};
callLambda(lambda);
}