Fix the lit failure on "loop-register.s" test. #155704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up of f3a5c16, which broke the test on arm64 due to incorrect use of the UNSUPPORTED tag.
Member
|
@llvm/pr-subscribers-tools-llvm-exegesis Author: Haowei (zeroomega) ChangesThis is a follow up of f3a5c16, which broke the test on arm64 due to incorrect use of the UNSUPPORTED tag. Full diff: https://github.com/llvm/llvm-project/pull/155704.diff 1 Files Affected:
diff --git a/llvm/test/tools/llvm-exegesis/AArch64/loop-register.s b/llvm/test/tools/llvm-exegesis/AArch64/loop-register.s
index 632088455e75a..db8f7a06b30a3 100644
--- a/llvm/test/tools/llvm-exegesis/AArch64/loop-register.s
+++ b/llvm/test/tools/llvm-exegesis/AArch64/loop-register.s
@@ -2,7 +2,7 @@
; generate extra function prologue instructions that interfere with matching
; the STR of X19. Disable this for now.
;
-; UNSUPPORTED: *
+; UNSUPPORTED: target={{.*}}
REQUIRES: aarch64-registered-target, asserts
|
Contributor
Author
|
See the error message on #155624 |
gulfemsavrun
approved these changes
Aug 27, 2025
Collaborator
|
Sorry about this, thanks for fixing! |
Contributor
|
|
Contributor
How? The original patch that caused this hasn't been backported to that branch (as far as I'm aware, and searching through the commit logs, there haven't beeen any exegesis backports). |
Contributor
|
LOL, seems our devops did a terrible job. Yeah, the release/21.x build wasn't actually release/21.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of f3a5c16, which broke the test on arm64 due to incorrect use of the UNSUPPORTED tag.