[BOLT] Enable lit internal shell by default

[boomanaiden154]

This patch enables lit's internal shell by default now that all
REQUIRES: shell tests have been update to not require shell features not
available in lit and all unresolved tests have been fixed.

This should speed up test runtime by a bit and will give nicer error
messaging.

Fixes #102701.

[llvmbot]

@llvm/pr-subscribers-bolt

Author: Aiden Grossman (boomanaiden154)

Changes

This patch enables lit's internal shell by default now that all
REQUIRES: shell tests have been update to not require shell features not
available in lit and all unresolved tests have been fixed.

This should speed up test runtime by a bit and will give nicer error
messaging.

Fixes #102701.

---

Full diff: https://github.com/llvm/llvm-project/pull/156083.diff

1 Files Affected:

• (modified) bolt/test/lit.cfg.py (+12-1)

diff --git a/bolt/test/lit.cfg.py b/bolt/test/lit.cfg.py
index 0d05229be2bf3..bef570ba50a04 100644
--- a/bolt/test/lit.cfg.py
+++ b/bolt/test/lit.cfg.py
@@ -18,11 +18,22 @@
 # name: The name of this test suite.
 config.name = "BOLT"
 
+# TODO: Consolidate the logic for turning on the internal shell by default for all LLVM test suites.
+# See https://github.com/llvm/llvm-project/issues/106636 for more details.
+#
+# We prefer the lit internal shell which provides a better user experience on failures
+# and is faster unless the user explicitly disables it with LIT_USE_INTERNAL_SHELL=0
+# env var.
+use_lit_shell = True
+lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL")
+if lit_shell_env:
+    use_lit_shell = lit.util.pythonize_bool(lit_shell_env)
+
 # testFormat: The test format to use to interpret tests.
 #
 # For now we require '&&' between commands, until they get globally killed and
 # the test runner updated.
-config.test_format = lit.formats.ShTest(not llvm_config.use_lit_shell)
+config.test_format = lit.formats.ShTest(execute_external=not use_lit_shell)
 
 # suffixes: A list of file extensions to treat as test files.
 config.suffixes = [

[maksfb]

Thanks!

[zmodem]

We're seeing bolt/test/runtime/instrumentation-indirect-2.c fail (hang) after this. (https://crbug.com/442483657)

I see it still has REQUIRES: shell but that doesn't seem to help:

llvm-project/bolt/test/runtime/instrumentation-indirect-2.c

Line 53 in 9a1e478

REQUIRES: system-linux,shell,fuser

I don't see the failure on any of the bolt buildbots, but those bots don't seem to have built anything for months, e.g. https://lab.llvm.org/buildbot/#/builders/113/builds/8245 is the last build on bolt-x86_64-ubuntu-clang and it seems to be a month old.

We'll work around this by excluding the test from our builds for now, but it would be great if someone could look into it.